Skip to content

[Fix] avoid relying on indexOf's HasProperty+Get semantics, unlike includes's bare Get #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajanpanth wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −8
Open

[Fix] avoid relying on indexOf's HasProperty+Get semantics, unlike includes's bare Get #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions implementation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,14 @@ var ToIntegerOrInfinity = require('es-abstract/2025/ToIntegerOrInfinity');
var ToLength = require('es-abstract/2025/ToLength');
var ToObject = require('es-object-atoms/ToObject');
var SameValueZero = require('es-abstract/2025/SameValueZero');
var $isNaN = require('math-intrinsics/isNaN');
var $isFinite = require('math-intrinsics/isFinite');
var $max = require('math-intrinsics/max');
var GetIntrinsic = require('get-intrinsic');
var callBound = require('call-bound');
var isString = require('is-string');

var $charAt = callBound('String.prototype.charAt');
var $indexOf = GetIntrinsic('%Array.prototype.indexOf%'); // TODO: use callBind.apply without breaking IE 8

module.exports = function includes(searchElement) {
var fromIndex = arguments.length > 1 ? ToIntegerOrInfinity(arguments[1]) : 0;
if ($indexOf && !$isNaN(searchElement) && $isFinite(fromIndex) && typeof searchElement !== 'undefined') {
return $indexOf.apply(this, arguments) > -1;
}

var O = ToObject(this);
var length = ToLength(O.length);
Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
"define-properties": "^1.2.1",
"es-abstract": "^1.24.2",
"es-object-atoms": "^1.1.2",
"get-intrinsic": "^1.3.0",
"is-string": "^1.1.1",
"math-intrinsics": "^1.1.0"
},
Expand Down
20 changes: 20 additions & 0 deletions test/tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,4 +91,24 @@ module.exports = function (includes, t) {

st.end();
});

t.test(
'exotic objects: uses Get, not HasProperty, unlike indexOf',
{ skip: typeof Proxy !== 'function' },
function (st) {
var target = [1, 2, 3, 4, 5];
var proxy = new Proxy(target, {
has: function () { return false; },
get: function (targ, k, r) { return Reflect.get(targ, k, r); }
});

st.equal(
true,
includes(proxy, 3),
'a lying `has` trap does not stop an element visible via `get` from being found'
);

st.end();
}
);
};
Loading