Clamp narrow map-key parameter ranges (#5279) - #5279
Closed
saitcakmak wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116546189. |
Summary: Prevent `MapKeyToFloat` from failing model initialization when distinct progression values span less than the minimum width supported by `RangeParameter`. Preserve the upper bound and expand the lower bound downward to the next representable valid value. Share the minimum-width constant with `RangeParameter` and cover inferred and configured bounds at and below the threshold. Reviewed By: rpanchal1996 Differential Revision: D116546189
meta-codesync
Bot
changed the title
saitcakmak
force-pushed
the
export-D116546189
branch
from
August 19, 2026 14:13
7eadea7 to
4304825
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5279 +/- ##
=======================================
Coverage 96.58% 96.59%
=======================================
Files 621 621
Lines 70867 70890 +23
=======================================
+ Hits 68449 68477 +28
+ Misses 2418 2413 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in 6e711c8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Prevent
MapKeyToFloatfrom failing model initialization when distinct progression values span less than the minimum width supported byRangeParameter. Preserve the upper bound and expand the lower bound downward to the next representable valid value. Share the minimum-width constant withRangeParameterand cover inferred and configured bounds at and below the threshold.Reviewed By: rpanchal1996
Differential Revision: D116546189