Skip to content

refactor: Migrate to js interop - #4

Closed
krille-chan wants to merge 2 commits into
mainfrom
krille/migrate-to-js-interop
Closed

refactor: Migrate to js interop#4
krille-chan wants to merge 2 commits into
mainfrom
krille/migrate-to-js-interop

Conversation

@krille-chan

Copy link
Copy Markdown
Contributor

No description provided.

@krille-chan
krille-chan force-pushed the krille/migrate-to-js-interop branch 3 times, most recently from 416ce31 to b331a50 Compare December 24, 2025 09:54
Comment thread .dart_tool/package_config.json Outdated
"packages": [
{
"name": "args",
"rootUri": "file:///Users/christianpauly/.pub-cache/hosted/pub.dev/args-2.7.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems incorrect to me??

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes .dart_tool should be in .gitignore. I've added it

Comment thread lib/src/web.dart Outdated
setTabs(name, getTabs(name) + 1);

window.onUnload.listen((_) {
void onunloadCallback(web.Event event) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you make it camel case?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

@krille-chan
krille-chan force-pushed the krille/migrate-to-js-interop branch from b331a50 to 4442394 Compare January 2, 2026 08:31
@nikzen nikzen closed this Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants