♻️ Simplify database readiness checks

.github/workflows/test-backend.yml

@@ -26,7 +26,7 @@ jobs:
         with:
           version: "latest-known"
       - run: docker compose down -v --remove-orphans
-      - run: docker compose up -d db mailpit
+      - run: docker compose up -d --wait db mailpit
       - name: Migrate DB
         run: uv run bash scripts/prestart.sh
         working-directory: backend

backend/README.md

@@ -78,7 +78,7 @@ If your stack is already up and you just want to run the tests, you can use:
 docker compose exec backend bash scripts/tests-start.sh
 ```
 
-The `/app/backend/scripts/tests-start.sh` script calls `pytest` after making sure that the rest of the stack is running. If you need to pass extra arguments to `pytest`, you can pass them to that command and they will be forwarded.
+The `/app/backend/scripts/tests-start.sh` script calls `pytest`. If you need to pass extra arguments to `pytest`, you can pass them to that command and they will be forwarded.
 
 For example, to stop on first error:
 

backend/app/core/db.py

@@ -4,7 +4,7 @@
 from app.core.config import settings
 from app.models import User, UserCreate
 
-engine = create_engine(str(settings.DATABASE_URL))
+engine = create_engine(str(settings.DATABASE_URL), pool_pre_ping=True)
 
 
 # make sure all SQLModel models are imported (app.models) before initializing DB

backend/pyproject.toml

@@ -7,7 +7,6 @@ dependencies = [
     "fastapi[standard]>=0.141.1,<1.0.0",
     "python-multipart<1.0.0,>=0.0.27",
     "email-validator<3.0.0.0,>=2.1.0.post1",
-    "tenacity<10.0.0,>=8.2.3",
     "pydantic>2.0",
     "emails>=1.1.2,<2.0",
     "jinja2<4.0.0,>=3.1.4",

backend/scripts/prestart.sh

@@ -3,9 +3,6 @@
 set -e
 set -x
 
-# Let the DB start
-python app/backend_pre_start.py
-
 # Run migrations
 alembic upgrade head
 

backend/scripts/tests-start.sh

@@ -2,6 +2,4 @@
 set -e
 set -x
 
-python app/tests_pre_start.py
-
 bash scripts/test.sh "$@"