[api-v3] shorten range to 89 days for functional tests - #212
Open
erayaydin wants to merge 1 commit into
Open
Conversation
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the run_checks.py functional check to adjust the search_events time window and to change how the start boundary is represented, aiming to exercise mixed input types for search_events.
Changes:
- Change
create_rangeto returnstartas adatetime(instead of epoch ms) andendas epoch milliseconds. - Reduce the queried range from 90 days to 89 days.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
erayaydin
force-pushed
the
test/fix-functional-tests-range
branch
from
August 3, 2026 17:13
893d6e5 to
b651719
Compare
erayaydin
force-pushed
the
test/fix-functional-tests-range
branch
from
August 3, 2026 17:21
b651719 to
43967ef
Compare
erayaydin
force-pushed
the
test/fix-functional-tests-range
branch
from
August 3, 2026 17:24
43967ef to
6bfe038
Compare
Reduced the window from 90 to 89 days. A full 90-day range hits the upper bound of what the API accepts
erayaydin
force-pushed
the
test/fix-functional-tests-range
branch
from
August 3, 2026 17:49
6bfe038 to
f057f21
Compare
erayaydin
marked this pull request as ready for review
August 3, 2026 17:50
mcnulty-fp
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The window is also reduced from 90 to 89 days, since a full 90-day range hits the upper bound of what the API accepts.