Skip to content

[api-v3] shorten range to 89 days for functional tests - #212

Open
erayaydin wants to merge 1 commit into
api-v3from
test/fix-functional-tests-range
Open

[api-v3] shorten range to 89 days for functional tests#212
erayaydin wants to merge 1 commit into
api-v3from
test/fix-functional-tests-range

Conversation

@erayaydin

@erayaydin erayaydin commented Aug 3, 2026

Copy link
Copy Markdown
Member

Description

The window is also reduced from 90 to 89 days, since a full 90-day range hits the upper bound of what the API accepts.

@erayaydin
erayaydin requested a review from Copilot August 3, 2026 17:07
@erayaydin erayaydin self-assigned this Aug 3, 2026
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
6011 5060 84% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: f057f21 by action🐍

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the run_checks.py functional check to adjust the search_events time window and to change how the start boundary is represented, aiming to exercise mixed input types for search_events.

Changes:

  • Change create_range to return start as a datetime (instead of epoch ms) and end as epoch milliseconds.
  • Reduce the queried range from 90 days to 89 days.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread run_checks.py Outdated
@erayaydin
erayaydin force-pushed the test/fix-functional-tests-range branch from 893d6e5 to b651719 Compare August 3, 2026 17:13
@erayaydin erayaydin changed the title [FunctionalTest] Pass datetime and shorten range to 89 days [api-v3] shorten range to 89 days for functional tests Aug 3, 2026
@erayaydin
erayaydin requested a review from Copilot August 3, 2026 17:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Reduced the window from 90 to 89 days. A full 90-day range hits
the upper bound of what the API accepts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants