Skip to content

chore: add @dcoric and @fabiovincenzi to MAINTAINERS.md and website#1647

Open
jescalada wants to merge 2 commits into
mainfrom
add-fabio-and-denis-as-maintainers
Open

chore: add @dcoric and @fabiovincenzi to MAINTAINERS.md and website#1647
jescalada wants to merge 2 commits into
mainfrom
add-fabio-and-denis-as-maintainers

Conversation

@jescalada

@jescalada jescalada commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Description

Adds @dcoric and @fabiovincenzi to MAINTAINERS.md and website.

Related Issue

Relates to #1646

Checklist

General

@jescalada
jescalada requested a review from a team as a code owner July 16, 2026 03:02
@netlify

netlify Bot commented Jul 16, 2026

Copy link
Copy Markdown

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit cfbc81b
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/6a58c2394caa14000833f58a

@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@06kellyjac 06kellyjac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

maybe merge after access is granted?

Also Denis's email is shorter, if that's correct we're all good. The only email I've seen for him on commits is a gmail.

Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
@jescalada

Copy link
Copy Markdown
Contributor Author

@06kellyjac Thanks! We just agreed to set our emails to the ones we actually commit with for consistency. 👍🏼

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.89%. Comparing base (096a049) to head (cfbc81b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1647      +/-   ##
==========================================
+ Coverage   85.75%   85.89%   +0.13%     
==========================================
  Files          85       85              
  Lines        8448     8448              
  Branches     1457     1457              
==========================================
+ Hits         7245     7256      +11     
+ Misses       1172     1162      -10     
+ Partials       31       30       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@06kellyjac

Copy link
Copy Markdown
Contributor

Oh, you don't have to use your commit emails, use whatever you'd be ok with receiving the odd email 🙂
Technically I commit (to this project) with jack@ but I've put jack+finos@ to hopefully identify when I get an email related to this work 🙂

I just wanted to check it was an actual email address 😅

Feel free to put them back to gr-oss domains if that's best, or don't totally up to you guys IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants