chore: add @dcoric and @fabiovincenzi to MAINTAINERS.md and website#1647
chore: add @dcoric and @fabiovincenzi to MAINTAINERS.md and website#1647jescalada wants to merge 2 commits into
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
06kellyjac
left a comment
There was a problem hiding this comment.
LGTM
maybe merge after access is granted?
Also Denis's email is shorter, if that's correct we're all good. The only email I've seen for him on commits is a gmail.
Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
|
@06kellyjac Thanks! We just agreed to set our emails to the ones we actually commit with for consistency. 👍🏼 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1647 +/- ##
==========================================
+ Coverage 85.75% 85.89% +0.13%
==========================================
Files 85 85
Lines 8448 8448
Branches 1457 1457
==========================================
+ Hits 7245 7256 +11
+ Misses 1172 1162 -10
+ Partials 31 30 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Oh, you don't have to use your commit emails, use whatever you'd be ok with receiving the odd email 🙂 I just wanted to check it was an actual email address 😅 Feel free to put them back to gr-oss domains if that's best, or don't totally up to you guys IMO |
Description
Adds @dcoric and @fabiovincenzi to
MAINTAINERS.mdand website.Related Issue
Relates to #1646
Checklist
General