fix(bigquery-firestore-export): apply DISPLAY_NAME changes on update - #2980
Open
IzaakGough wants to merge 1 commit into
Open
fix(bigquery-firestore-export): apply DISPLAY_NAME changes on update#2980IzaakGough wants to merge 1 commit into
IzaakGough wants to merge 1 commit into
Conversation
DISPLAY_NAME is mutable in the kit, but the update mask never included display_name, so editing it and redeploying reported success and left the scheduled query's name unchanged.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for updating the display name of a BigQuery Data Transfer Service configuration when it changes. It updates constructUpdateTransferConfigRequest to include display_name in the update mask and the updated configuration when a change is detected. Additionally, it includes corresponding unit tests to verify this behavior. There are no review comments, and we have no feedback to provide.
IzaakGough
marked this pull request as ready for review
August 27, 2026 10:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DISPLAY_NAMEisimmutable: trueupstream but mutable in the kit, andconstructUpdateTransferConfigRequestnever addsdisplay_nameto the update mask. Editing it and redeploying reports success and changes nothing.What changed
display_namejoins the mask when it differs, matching thescheduleandnotification_pubsub_topiccomparisons beside it.Verification
Against a live transfer config: with
display_namein the mask the rename lands, with it omitted the same request body is silently ignored. Two unit cases added, full suite 21 passed,tsc -bclean.Notes
The alternative was making the param immutable to match upstream. This keeps the kit's more flexible behaviour.
Tracked in #2974 (parity analysis),
DISPLAY_NAMEparams row.