fix(firestore-genai-chatbot): restore the extension's 540s timeout - #2986
fix(firestore-genai-chatbot): restore the extension's 540s timeout#2986CorieW wants to merge 1 commit into
Conversation
extension.yaml sets `timeout: 540s` on generateMessage; the kit set no timeoutSeconds, so the function took the 60s default and long generations timed out mid-stream. #2974 ranks this the kit's highest-priority gap. The timeout rides on envDeployOptions() so library consumers see it in DeployTimeOptions and the deploy-options suite covers it.
There was a problem hiding this comment.
Code Review
This pull request configures the Firestore GenAI Chatbot function's timeout to 540 seconds to align with the extension.yaml specification, preventing long generations from timing out under the default 60-second limit. The changes update the deployment options configuration, interface definitions, function trigger setup, and include a corresponding unit test. There are no review comments, and I have no feedback to provide.
IzaakGough
left a comment
There was a problem hiding this comment.
Lgtm with one nit:
On the "library consumers get it too" line in the description: the 540 lives in envDeployOptions(), which index.ts imports but does not re-export, and lib.ts does not export it either. So someone following the README's "import from ./lib" path for their own trigger does not pick it up.
Adding envDeployOptions to the lib.ts re-exports would cover it.
Summary
timeout: 540songenerateMessage, tracked as the kit's highest-priority gap in Kits parity issues #2974: the kit set notimeoutSeconds, so the function took the 60s default and long generations timed out mid-stream.envDeployOptions()/DeployTimeOptionsrather than inline, so library consumers get it too and the deploy-options suite asserts it.Testing
timeoutSeconds === 540.tsc --noEmitclean; all 22 tests pass.npm packed, re-vendored into its function-kits source; discovery endpoint spec carriestimeoutSeconds: 540(with theAPI_KEYsecret binding intact).a91f6c2e,overrides,vertex) — successful updates, 0 failures.firebase functions:list: all three deployedgenerateMessagefunctions reporttimeoutSeconds: 540.