fix(ci): pin actions/checkout and setup-node to v7 (Node 20 deprecation) - #2991
Draft
cabljac wants to merge 1 commit into
Draft
fix(ci): pin actions/checkout and setup-node to v7 (Node 20 deprecation)#2991cabljac wants to merge 1 commit into
cabljac wants to merge 1 commit into
Conversation
The v4 SHAs pinned in release-kit.yaml and npm_publish_bq_scripts.yml declare a Node 20 runtime, which GitHub is deprecating. checkout v7.0.1 and setup-node v7.0.0 run on Node 24. setup-node v7 dropped the always-auth input, so remove it (false was the default behaviour). The read-only test job no longer persists git credentials. Fixes #2977
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
cabljac
added a commit
that referenced
this pull request
Aug 27, 2026
…s, v7 action pins (#2990) Fixes #2978. - **npm version silently skipped git commit/tag** (.git not next to kit's package.json): bump now uses --no-git-tag-version, with explicit commit + annotated per-kit tag (`<pkg>@<version>`) from repo root. Commit fails loudly if nothing staged. - **Re-runs recomputed the same version from package.json and 403'd**: next version now derived from the registry (`npm view <pkg> time`, includes unpublished versions) unioned with package.json. - **Bump level silently ignored when an rc existed**: level now applied to the highest stable version; an rc line continues only if the requested level doesn't open a higher one. - **npm-shrinkwrap.json bumped but not committed**: now staged in the release commit. - **Concurrent runs raced the branch push**: workflow-level concurrency group; push is atomic and happens only after a successful publish. Action pin bumps for #2977 split out into #2991; the two merge independently (non-overlapping hunks). Verified: dry-run dispatch green, computes 0.0.2-rc.1 for rtdb (the version #2978 requires); version logic passed 10 synthetic registry scenarios locally. The non-dry-run commit/tag/push path has not been exercised live.
cabljac
added a commit
that referenced
this pull request
Aug 27, 2026
Syncs release-kit.yaml byte-for-byte with the version that landed on kits in #2990. This copy never executes (Release Kit is always dispatched from kits; next has no kits/ directories); it only lists the workflow in the Actions UI, and it had drifted to show the old broken versioning logic. No behavior change. Will need re-syncing if #2991 lands on kits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2977.
Other workflows (test.yml, validate.yml, release.yml, readmes-updated.yml) pin v3 SHAs and warn too; left out of scope here.
Verified via a green dry-run dispatch of Release Kit with these pins (run 33062266667); v3→v7 has no config-breaking changes for these workflows (package-manager-cache auto-detection is inert: no packageManager fields).