fix(release-kit): adopt npm trusted publishing and pin releases to kits - #2993
Merged
Conversation
Publishing failed with ENEEDAUTH: the workflow authenticated against wombat-dressing-room with secrets.NPM_TOKEN, which no longer exists. The copy of this workflow on next had already moved to npm trusted publishing (id-token: write, npm publish --provenance, no token) and pinned checkout to the kits branch; the successful Aug 20-26 releases all ran that way. #2992 then overwrote that copy with this one, losing the working auth. Adopt the same design here: OIDC trusted publishing, and checkout, push, and release target hardcoded to kits so the file behaves identically from whichever branch it is dispatched. The non-branch-ref dispatch guard is dropped since the push no longer derives from the dispatched ref. Not verified live: npm dist-tag add on the stable path may still need auth that trusted publishing only grants to publish itself.
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
cabljac
marked this pull request as ready for review
August 27, 2026 17:04
dackers86
approved these changes
Aug 27, 2026
cabljac
added a commit
that referenced
this pull request
Aug 27, 2026
Syncs release-kit.yaml byte-for-byte with the #2993 version on kits (trusted publishing, checkout/push/release pinned to kits). The #2992 copy on next authenticated via the removed NPM_TOKEN and checked out the dispatched ref, so dispatching from next failed at the test job. The #2993 file is dispatch-ref-agnostic, making the two copies safely identical. No behavior change beyond fixing dispatch-from-next.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yesterday's release attempt failed with ENEEDAUTH: this copy of the workflow still authenticates against wombat-dressing-room via secrets.NPM_TOKEN, which no longer exists in the repo. The next branch's copy had already moved to npm trusted publishing (id-token: write, npm publish --provenance, no token, checkout pinned to kits) and every successful Aug 20-26 release ran through it; #2992 then overwrote it with this copy, losing the working auth path.
This ports that design onto the fixed versioning logic: OIDC trusted publishing, and checkout/push/release-target hardcoded to kits so the file behaves identically from any dispatch ref (safe to re-sync to next afterwards). The non-branch dispatch guard is dropped since the push no longer derives from the dispatched ref.
Verified via dry-run dispatch (link in comments). Caveats: npm dist-tag add on the stable path may still need auth beyond what trusted publishing grants to publish itself (pre-existing, prerelease path unaffected); the real publish path is exercised only by the next actual release.