fix(kits): allow patch and minor updates to firebase-functions - #2996
Open
IzaakGough wants to merge 1 commit into
Open
fix(kits): allow patch and minor updates to firebase-functions#2996IzaakGough wants to merge 1 commit into
IzaakGough wants to merge 1 commit into
Conversation
Kits pinned firebase-functions to exactly 7.3.2. When the wrapper project the CLI scaffolds resolves any other 7.x, npm gives the kit a nested copy, which then resolves firebase-admin to the kit's 14.x rather than the wrapper's 13.x. That pulls a second @google-cloud/firestore into the type program and the build fails with TS6200, since both copies declare the global FirebaseFirestore namespace. Shrinkwraps are updated to match; resolved versions are unchanged.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the dependency version of firebase-functions from a pinned version (7.3.2) to a flexible caret range (^7.3.2) across multiple kits' package.json and npm-shrinkwrap.json files. There are no review comments, and I have no feedback to provide.
IzaakGough
marked this pull request as ready for review
August 28, 2026 14:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2995
Every kit pinned
firebase-functionsto exactly7.3.2. When the wrapper thatfunctions:kits:installscaffolds resolves any other 7.x, npm gives the kit a nested copy, whosefirebase-adminresolves to the kit's14.xinstead of the wrapper's13.x. That pulls a second@google-cloud/firestoreinto the type program and the build fails with TS6200, since both copies declare the globalFirebaseFirestorenamespace.firebase-functionsis now^7.3.2in the 12 kits that declare it, with shrinkwraps updated to match. No resolved versions change, and regenerating each shrinkwrap withnpm install --package-lock-onlygives no diff.Verified by reproducing the six errors with a wrapper at 7.2.5 and at 7.3.0, then confirming a wrapper on 7.3.2 or newer installs one copy and builds.