Skip to content

[FCM] update testing code #8535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
milaGGL wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

[FCM] update testing code #8535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...aging/src/test/java/com/google/firebase/messaging/DisplayNotificationChannelRoboTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public void setup() throws Exception {
}

@Test
@Config(minSdk = 23, maxSdk = 25) // getActiveNotifications() not available <23
@Config(minSdk = Config.OLDEST_SDK, maxSdk = 25) // getActiveNotifications() not available <23
public void channelIgnored_belowApi26TargetSdk25() throws Exception {
setTargetSdkVersion(25);
createDisplayNotification(context, createNotificationMessage(), executor).handleNotification();
Expand All @@ -83,7 +83,7 @@ public void channelIgnored_belowApi26TargetSdk25() throws Exception {
}

@Test
@Config(minSdk = 23, maxSdk = 25) // getActiveNotifications() not available <23
@Config(minSdk = Config.OLDEST_SDK, maxSdk = 25) // getActiveNotifications() not available <23
public void channelIgnored_belowApi26TargetSdk26() throws Exception {
setTargetSdkVersion(26);
createDisplayNotification(context, createNotificationMessage(), executor).handleNotification();
Expand Down
6 changes: 3 additions & 3 deletions ...se-messaging/src/test/java/com/google/firebase/messaging/DisplayNotificationRoboTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ public void testClickActionAndLink() {

/** Test that a valid notification with color is displayed. */
@Test
@Config(sdk = Build.VERSION_CODES.M)
@Config(sdk = Config.OLDEST_SDK)
public void testColor() {
final String color = "#123456";
Bundle data = new Bundle();
Expand All @@ -489,7 +489,7 @@ public void testColor() {
}

@Test
@Config(sdk = Build.VERSION_CODES.M)
@Config(sdk = Config.OLDEST_SDK)
public void testNoColor() {
Bundle data = new Bundle();
data.putString(KEY_TITLE, "title 123");
Expand All @@ -503,7 +503,7 @@ public void testNoColor() {

/** Test that the user can choose the default color via AndroidManifest metadata. */
@Test
@Config(sdk = Build.VERSION_CODES.M)
@Config(sdk = Config.OLDEST_SDK)
public void testColorFromMetadata() {
Bundle metadata = new Bundle();
metadata.putInt(
Expand Down
Loading