Skip building the current major version in the next major lane - #1103
Open
Watson1978 wants to merge 1 commit into
Open
Skip building the current major version in the next major lane#1103Watson1978 wants to merge 1 commit into
Watson1978 wants to merge 1 commit into
Conversation
"Build next major" ran "rake yum:build" twice: once for the current version
and once more for the v7 one in v7-test. The first build's artifacts are
discarded, since all three upload-artifact steps for them are guarded by
next-major != 'true', so it was pure waste. The deb counterpart already
guards the step this way; only the rpm one was left behind.
Measured on the AlmaLinux 10 x86_64 lane of run 30994758570:
* Build rake yum:build (v6) 8m27s
* Build next major rake yum:build (v6) 6m56s <- discarded
rake yum:build (v7) 6m16s
To keep the RHEL9 and RHEL10 ABI checks meaningful, move them after the v7
build and point them at whichever repositories directory the lane actually
produced. This makes the next major lane check the v7 packages instead of
repeating what the "Build" lane already checks.
Also fail loudly when no rpm is found to check, so that a wrong directory
cannot be mistaken for a clean result.
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978
force-pushed
the
fix-nex-major-build-rpm
branch
from
August 6, 2026 01:43
a9a2dad to
b2b9e9d
Compare
Contributor
Author
Reduced 17m in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Build next major" ran "rake yum:build" twice: once for the current version and once more for the v7 one in v7-test. The first build's artifacts are discarded, since all three upload-artifact steps for them are guarded by next-major != 'true', so it was pure waste. The deb counterpart already guards the step this way; only the rpm one was left behind.
Measured on the AlmaLinux 10 x86_64 lane of run 30994758570:
rake yum:build (v7) 6m16s
To keep the RHEL9 and RHEL10 ABI checks meaningful, move them after the v7 build and point them at whichever repositories directory the lane actually produced. This makes the next major lane check the v7 packages instead of repeating what the "Build" lane already checks.
Also fail loudly when no rpm is found to check, so that a wrong directory cannot be mistaken for a clean result.