update env name for RECOVER_WARNING_THRESHOLD - #6152
Conversation
Signed-off-by: xliuqq <xlzq1992@gmail.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6152 +/- ##
=======================================
Coverage 65.13% 65.13%
=======================================
Files 485 485
Lines 34039 34039
=======================================
Hits 22171 22171
Misses 10127 10127
Partials 1741 1741 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR fixes a Helm chart typo so the CSI daemonset sets the environment variable name that the recovery code actually reads (RECOVER_WARNING_THRESHOLD), aligning chart configuration with runtime behavior and addressing #6151.
Changes:
- Rename the rendered env var from
REVOCER_WARNING_THRESHOLDtoRECOVER_WARNING_THRESHOLDin the CSI daemonset template.
Suppressed comments (1)
charts/fluid/fluid/templates/csi/daemonset.yaml:96
- The conditional
if .Values.csi.recoverWarningThresholdwill evaluate to false when the value is explicitly set to0, so--set csi.recoverWarningThreshold=0won’t render the env var even though the CSI code acceptsRECOVER_WARNING_THRESHOLD=0. Use a key-existence check so explicit zero values are still honored.
{{- if .Values.csi.recoverWarningThreshold }}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| {{- if .Values.csi.recoverWarningThreshold }} | ||
| - name: REVOCER_WARNING_THRESHOLD | ||
| value: {{ .Values.csi.recoverWarningThreshold | quote}} | ||
| - name: RECOVER_WARNING_THRESHOLD | ||
| value: {{ .Values.csi.recoverWarningThreshold | quote }} | ||
| {{- end }} |



Ⅰ. Describe what this PR does
correct the env name for RECOVER_WARNING_THRESHOLD
Ⅱ. Does this pull request fix one issue?
fixes #6151
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews