Skip to content

update env name for RECOVER_WARNING_THRESHOLD - #6152

Open
xliuqq wants to merge 1 commit into
fluid-cloudnative:masterfrom
xliuqq:env-name
Open

update env name for RECOVER_WARNING_THRESHOLD#6152
xliuqq wants to merge 1 commit into
fluid-cloudnative:masterfrom
xliuqq:env-name

Conversation

@xliuqq

@xliuqq xliuqq commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Ⅰ. Describe what this PR does

correct the env name for RECOVER_WARNING_THRESHOLD

Ⅱ. Does this pull request fix one issue?

fixes #6151

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: xliuqq <xlzq1992@gmail.com>
@xliuqq
xliuqq requested a review from cheyang August 5, 2026 12:33
@sonarqubecloud

sonarqubecloud Bot commented Aug 5, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.13%. Comparing base (7c00ed2) to head (53d2017).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6152   +/-   ##
=======================================
  Coverage   65.13%   65.13%           
=======================================
  Files         485      485           
  Lines       34039    34039           
=======================================
  Hits        22171    22171           
  Misses      10127    10127           
  Partials     1741     1741           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a Helm chart typo so the CSI daemonset sets the environment variable name that the recovery code actually reads (RECOVER_WARNING_THRESHOLD), aligning chart configuration with runtime behavior and addressing #6151.

Changes:

  • Rename the rendered env var from REVOCER_WARNING_THRESHOLD to RECOVER_WARNING_THRESHOLD in the CSI daemonset template.
Suppressed comments (1)

charts/fluid/fluid/templates/csi/daemonset.yaml:96

  • The conditional if .Values.csi.recoverWarningThreshold will evaluate to false when the value is explicitly set to 0, so --set csi.recoverWarningThreshold=0 won’t render the env var even though the CSI code accepts RECOVER_WARNING_THRESHOLD=0. Use a key-existence check so explicit zero values are still honored.
          {{- if .Values.csi.recoverWarningThreshold }}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 96 to 99
{{- if .Values.csi.recoverWarningThreshold }}
- name: REVOCER_WARNING_THRESHOLD
value: {{ .Values.csi.recoverWarningThreshold | quote}}
- name: RECOVER_WARNING_THRESHOLD
value: {{ .Values.csi.recoverWarningThreshold | quote }}
{{- end }}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(helm): csi.recoverWarningThreshold renders an unused environment variable

2 participants