Prepare for long filenames in Flutter repo#9888
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Flutter SDK update command to clone the repository with --no-checkout and configure core.longpaths to true on Windows to prevent "Filename too long" errors. It also adds a doc comment to runAll in tool/lib/utils.dart. The review feedback points out that if a developer already has the SDK directory cloned, they will bypass the clone block and go straight to checkout, which could still fail if core.longpaths is not set. It is recommended to also run the git configuration in the update path.
| // engine/src/flutter/testing/ios_scenario_app/ios/Scenarios/ | ||
| // ScenariosUITests/ | ||
| // golden_platform_view_clippath_with_transform_multiple_clips_impeller_iPhone SE (3rd generation)_26.2_simulator.png'. | ||
| final gitLongFilesCommand = CliCommand.git([ |
Member
There was a problem hiding this comment.
can we just run this once before the if / else statement instead of calling it in each block?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While moving this repo to the Dart SDK, I hit this error on the windows bots:
https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8676373343835221969/+/u/build_devtools/stdout?format=raw
In this PR, I skip checking out 'master' on the 'git clone' command. Then run 'git config core.longpaths true' before checking out the appropriate commit.