Skip to content

[google_fonts] Remove failed loads from pendingFonts#12240

Open
Yusufihsangorgel wants to merge 1 commit into
flutter:mainfrom
Yusufihsangorgel:fix/google-fonts-pending-load-cleanup
Open

[google_fonts] Remove failed loads from pendingFonts#12240
Yusufihsangorgel wants to merge 1 commit into
flutter:mainfrom
Yusufihsangorgel:fix/google-fonts-pending-load-cleanup

Conversation

@Yusufihsangorgel

Copy link
Copy Markdown

Failed font loads remain in pendingFontFutures because the current cleanup
callback runs only after successful completion. As a result, every later
GoogleFonts.pendingFonts() call rethrows the same completed error.

This change removes a tracked load on either completion path while preserving
the original error for the caller currently awaiting pendingFonts(). It adds
regression coverage showing that the first call reports the load failure and a
later call is no longer poisoned by it.

Fixes flutter/flutter#182430.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@github-actions github-actions Bot added p: google_fonts triage-framework Should be looked at in framework triage labels Jul 18, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the google_fonts package to version 8.2.1. It ensures that failed font loads are removed from pendingFontFutures by replacing then with whenComplete on the loading future in google_fonts_base.dart. A unit test has been added to verify that pendingFonts correctly removes failed font loads. There are no review comments, and I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: google_fonts triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[google_font] pendingFonts() fails indefinitely after a single failed font loading

1 participant