[google_fonts] Remove failed loads from pendingFonts#12240
Open
Yusufihsangorgel wants to merge 1 commit into
Open
[google_fonts] Remove failed loads from pendingFonts#12240Yusufihsangorgel wants to merge 1 commit into
Yusufihsangorgel wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the google_fonts package to version 8.2.1. It ensures that failed font loads are removed from pendingFontFutures by replacing then with whenComplete on the loading future in google_fonts_base.dart. A unit test has been added to verify that pendingFonts correctly removes failed font loads. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed font loads remain in
pendingFontFuturesbecause the current cleanupcallback runs only after successful completion. As a result, every later
GoogleFonts.pendingFonts()call rethrows the same completed error.This change removes a tracked load on either completion path while preserving
the original error for the caller currently awaiting
pendingFonts(). It addsregression coverage showing that the first call reports the load failure and a
later call is no longer poisoned by it.
Fixes flutter/flutter#182430.
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2