ISSUE-78: Updates justinrainbow/json-schema to >=6.6 & fixes test - #79
ISSUE-78: Updates justinrainbow/json-schema to >=6.6 & fixes test#79DiegoPino wants to merge 7 commits into
Conversation
See \JsonSchema\Entity\ErrorBag::addError, constraint errors are an array and hold all the details inside that key, format top key is gone
|
Tests won't pass bc CI is set for PHP 7.1 (EOL for a while). Should I update CI & composer.json PHP to be more restrictive to PHP 8.1 > too and start targeting only 8.1+ ? |
|
@courtney-miles hi. Could you give this a look? You ok if we drop PHP 7.x ? Thanks a lot |
Coveralls reporting for 8.3
Allow extending classes to access these values, can't find a rational to have these private
PHP 8 supported sin 9.3 Not sure about the <10 here?
|
Hi @OriHoch or @roll maybe you can chime in? Or @courtney-miles if you missed my first message? The main issue is the current |
|
Hi @DiegoPino, @pdelboca might help |
|
Hello! Sorry, I'm not sure how can I help. I have never contributed to this repository nor have familiarity with it. I would let the maintainers chip in here. |
|
I think it should be fine to drop support for PHP 7, can also just ignore the error on the CI for this version |
|
if @courtney-miles is not available maybe we can add @DiegoPino to maintainers of this repo.. @roll |
|
@roll @OriHoch happy to step up and maintain this repo if @courtney-miles can't right now. Don't want to step on anyone , though. We have dependencies on frictionless data package libraries and release twice a year, so it's in our wheelhouse. |
|
@courtney-miles hi, just saw you are back and merged a pull. When you have some time could you please give this one a look? Appreciate it |
|
Hey @DiegoPino , Sorry for my absence. I want to review how the validation errors from json-schema are exposed because I think this would be a BC breakage. In which case, version numbering for this package would then need to be bumped up to version 2. And a decision would need to be made about ongoing support for version 1. The alternative is that we allow either version of json-schema, and acknowledge that the versions of tableschema-php does not determine the shape of the errors, rather the versions of its dependencies. It's not ideal, but it at least gives the options for the consumer to keep json-schema version down so their current usage does not break. |
|
Hi, thanks for your message and happy 😊 you are back. I am on the move
right now but will reflect (and suggest some ideas) on the schema issue by
the end of the day when (finally) in front of a computer
…On Tue, Jul 28, 2026 at 11:07 PM Courtney Miles ***@***.***> wrote:
*courtney-miles* left a comment (frictionlessdata/tableschema-php#79)
<#79 (comment)>
Hey @DiegoPino <https://github.com/DiegoPino> ,
Sorry for my absence.
I want to review how the validation errors from *json-schema* are exposed
because I think this would be a BC breakage.
In which case, version numbering for this package would then need to be
bumped up to version 2. And a decision would need to be made about ongoing
support for version 1.
The alternative is that we allow either version of *json-schema*, and
acknowledge that the versions of *tableschema-php* does not determine the
shape of the errors, rather the versions of its dependencies. It's not
ideal, but it at least gives the options for the consumer to keep
*json-schema* version down so their current usage does not break.
—
Reply to this email directly, view it on GitHub
<#79?email_source=notifications&email_token=ABU7ZZ6ZSXVKHNSZ5UCCSUL5HEI27A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJQHE3DQNZXGU2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5109687754>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABU7ZZ5AO3HGX4FTOGTV45L5HEI27AVCNFSNUABEKJSXA33TNF2G64TZHM4DKOJRGYYDGOB3JFZXG5LFHMZTOOJYGQ3DOOBUHGQXMAQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Overview
See #78
Updates
justinrainbow/json-schemaand fixes test that depends on returned array from the error bag object on validation error (see\JsonSchema\Entity\ErrorBag::addError)Also the phpunit schema was behind, this brings it up to 9.3
Schema Validator
descriptoranderrorproperties moved from private to protected. frictionlessdata/datapackage-php extends that class and needs access to those properties. If a better solution is to access plain accessors (e.g current errors accessor does internal revalidation so not suited for directly accessing already validated data), can do that too.Please preserve this line to notify @courtney-miles (lead of this repository)