Derive current wallet instead of copying it into every screen - #892
Open
DRadmir wants to merge 2 commits into
Open
Derive current wallet instead of copying it into every screen#892DRadmir wants to merge 2 commits into
DRadmir wants to merge 2 commits into
Conversation
- Screens observe the wallet row via WalletRequest; per-wallet content is rebuilt through identity on wallet change - Hoist the three tab NavigationStacks above the identity boundary and rename *NavigationStack views to *NavigationView - Root observes currentWalletId only for effects; legacy per-screen onChangeWallet syncs removed - Order deep-link navigation after the wallet switch via a RunLoop hop - Derive the wallets list checkmark from the session; dismiss the wallets sheet when the last wallet is deleted - Remove unused setCurrent(index:)
DRadmir
force-pushed
the
wt4/derive-current-wallet
branch
from
August 14, 2026 07:08
0197cad to
b93891a
Compare
gemcoder21
reviewed
Aug 14, 2026
|
|
||
| public let walletQuery: ObservableQuery<WalletRequest> | ||
| public var dbWallet: Wallet? { | ||
| public var dbWallet: Wallet { |
Contributor
There was a problem hiding this comment.
Suggested change
| public var dbWallet: Wallet { | |
| public var wallet: Wallet { |
can we do this then?
gemcoder21
approved these changes
Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current wallet is derived from a single source instead of being copied into every screen. Switching wallets rebuilds per-wallet screens automatically, and opening a push notification for another wallet now lands on the right screen reliably.
Closes #833