fix(fs): ignore ETIMEDOUT in scandir on network mounts#1217
Open
sentry[bot] wants to merge 2 commits into
Open
fix(fs): ignore ETIMEDOUT in scandir on network mounts#1217sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
Contributor
|
Contributor
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 5334 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 81.81% 81.82% +0.01%
==========================================
Files 423 423 —
Lines 29343 29343 —
Branches 19118 19119 +1
==========================================
+ Hits 24006 24009 +3
- Misses 5337 5334 -3
- Partials 1989 1988 -1Generated by Codecov Action |
sentry
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
ETIMEDOUTerrors encountered duringreaddiroperations on network or cloud-mounted filesystems (e.g., CloudStorage, Ubuntu server mounts) were being reported to Sentry. While the filesystem scan itself gracefully recovers from these transient errors by returning an empty list and continuing, theisIgnorableFileError()function did not includeETIMEDOUTin its allow-list. This led to noisy, spurious error reports in Sentry.This change updates
src/lib/dsn/fs-utils.tsto addETIMEDOUTto the list of ignorable file system error codes. This ensures that transient connection timeouts during filesystem scans are no longer captured by Sentry, reducing noise without altering the scan's behavior.Fixes CLI-1ZB
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.