fix(error-reporting): silence ValidationError for invalid trace IDs

[sentry]

Previously, ValidationError instances, specifically those arising from invalid trace IDs provided to commands like sentry.trace.view, sentry.trace.logs, and sentry.span.view, were being reported to Sentry as unhandled errors (CLI-1GP).

The root cause was that the classifySilenced() function in src/lib/error-reporting.ts did not explicitly recognize ValidationError as a user-input error that should be silenced. This led to noise in Sentry for expected user mistakes.

This fix addresses the issue by:

1. Adding "validation_error" to the SilenceReason union type.
2. Implementing a check for ValidationError within classifySilenced(), returning "validation_error" to prevent these errors from being reported.
3. Updating the module-level JSDoc comment in error-reporting.ts to reflect this new silencing rule.
4. Adjusting the corresponding test in test/lib/error-reporting.test.ts to assert that ValidationError is now correctly silenced.

Fixes CLI-1GP

_{Comment @sentry <feedback> on this PR to have Autofix iterate on the changes.}

[github-actions]

PR Preview Action v1.8.1
🚀 View preview at https://cli.sentry.dev/_preview/pr-1226/
Built to branch gh-pages at 2026-07-10 22:42 UTC. Preview will be ready when the GitHub Pages deployment is complete.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 6284299. Configure here.}

[cursor]

Stale ValidationError capture tests

Medium Severity

Silencing ValidationError in classifySilenced makes reportCliError return before withScope, but the integration tests at lines 491–526 still use capturedScopeTags with ValidationError and expect cli_error.* tags from the capture path. Those expectations no longer match behavior and the suite should fail.

Additional Locations (1)

• src/lib/error-reporting.ts#L98-L101

 

^{Reviewed by Cursor Bugbot for commit 6284299. Configure here.}

[sentry]

Bug: Silencing ValidationError causes reportCliError to return early, which will break new tests in this PR that expect Sentry tags to be set for this error type.
_{Severity: HIGH}

Suggested Fix

The new tests for ValidationError tagging should be removed or modified. Since ValidationError is now intentionally silenced and not reported to Sentry with scope, the tests that assert on its Sentry scope tags are no longer valid. Alternatively, if tagging is still desired, the early return in reportCliError for silenced errors needs to be reconsidered.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: src/lib/error-reporting.ts#L95-L97

Potential issue: The pull request modifies `classifySilenced` to treat `ValidationError`
as a silenced error. This change causes the `reportCliError` function to return early,
before `Sentry.withScope` is called. However, the PR also introduces new integration
tests that rely on a `capturedScopeTags` helper function. This helper mocks
`Sentry.withScope` to verify that specific tags are set for `ValidationError`. Because
`Sentry.withScope` is no longer invoked for these errors, the tests will receive an
empty set of tags, causing their assertions to fail and breaking the test suite.

Also affects:

• test/lib/error-reporting.test.ts:492~518

_{Did we get this right? 👍 / 👎 to inform future reviews.}