Skip to content

ref(chat)!: add task, Plugin dispatch, and Agent invocation Sources - #1737

Draft
dcramer wants to merge 4 commits into
mainfrom
codex/issue-1563-source-kinds
Draft

ref(chat)!: add task, Plugin dispatch, and Agent invocation Sources#1737
dcramer wants to merge 4 commits into
mainfrom
codex/issue-1563-source-kinds

Conversation

@dcramer

@dcramer dcramer commented Aug 29, 2026

Copy link
Copy Markdown
Member

Scheduled tasks, Event tasks, Plugin dispatches, and Agent invocations now set
the Source that caused each Turn. They no longer copy a Slack Source or the
parent Run's Source. Plugin background tasks use the Source saved on the Turn.

Slack tools use the Conversation Location and visibility. Actions on the
current Slack message still require a Slack Source. Slack reply instructions
require Delivery and a Slack Location. This lets scheduled Slack work reply to
Slack while an Agent invocation can use Slack tools without sending its result
to Slack.

Plugin dispatch callers must stop passing source; Junior now sets Plugin
dispatch Source. Legacy session Source and Destination reads remain only for
deployed data. TODOs state when to remove them. Scheduled task and Event task
tools still require Slack when users manage them. TODOs state that these tools
should later work from web and other Conversations.

Refs #1563

@vercel

vercel Bot commented Aug 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
junior-docs Ready Ready Preview Aug 29, 2026 10:26pm

Request Review

Comment thread packages/junior/src/chat/agent/types.ts
Comment thread packages/junior/src/chat/agent-dispatch/context.ts
Comment thread packages/junior/src/chat/source.ts
Comment thread packages/junior/src/chat/plugins/task-runner.ts

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2873322. Configure here.

)
source.kind === "slack" || source.kind === "web" || source.kind === "local"
? await loadConversationContextTranscriptEntries(record, source, runActor)
: []

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plugin tasks drop Slack context

Medium Severity

Prior public Slack thread evidence is now skipped whenever the Turn source is scheduled_task, event_task, plugin_dispatch, or agent_invocation. That decision uses the trigger Source, but conversation context is a Conversation Location and visibility concern. Plugin session.completed tasks for scheduled Slack work and Agent invocations therefore lose the public thread messages a completed run may have acted on.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2873322. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant