fix(mcp): reset dead sign-in state after auth errors - #1740
Merged
Conversation
Provider error callbacks left dead client/discovery credentials in place, and users could not unlink MCP plugins without tokens. Clear DCR state on error, allow MCP unlink, and surface incomplete MCP auth in App Home. Co-Authored-By: David Cramer <david@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Typecheck failed because test fixtures used authorization_server instead of authorizationServerUrl.
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
Superseded OAuth error callbacks could wipe live client/discovery state. Only clear durable DCR metadata when the session still owns the pending auth attempt.
sentry-junior
Bot
changed the title
dcramer
approved these changes
Aug 31, 2026
dcramer
marked this pull request as ready for review
August 31, 2026 00:22
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6cbd6a0. Configure here.
Error-callback DCR clears used a one-shot current-attempt check without the conversation lock, so a newer attempt could write credentials in between. Route cleanup through the same locked mutation path as success writes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1739.
After an MCP provider's auth server is replaced, Junior kept the old client registration and kept sending the same broken sign-in link. Users also could not unlink MCP accounts that never finished connecting.
This change:
/unlinkwork for MCP providersRequested by David Cramer.
--
View Junior Session [Sentry]