Skip to content

feat(nestjs): add orchestrion diagnostics-channel instrumentation#22176

Merged
isaacs merged 1 commit into
developfrom
isaacs/nestjs-orchestrion-impl
Jul 13, 2026
Merged

feat(nestjs): add orchestrion diagnostics-channel instrumentation#22176
isaacs merged 1 commit into
developfrom
isaacs/nestjs-orchestrion-impl

Conversation

@isaacs

@isaacs isaacs commented Jul 10, 2026

Copy link
Copy Markdown
Member

Add the NestJS channel subscriber in @sentry/nestjs, plus its code-transform config and channel names in @sentry/server-utils.

nestIntegration now uses the diagnostics-channel path when orchestrion is injected and the vendored OTel path otherwise. Only the span origin differs between the two implementations.

Fix: #20947
Fix: #20904
Fix: #20905
Fix: #20906
Fix: #20907
Fix: JS-2519
Fix: JS-2477
Fix: JS-2478
Fix: JS-2479
Fix: JS-2480

@isaacs isaacs requested review from a team as code owners July 10, 2026 03:36
@isaacs isaacs requested review from JPeer264, andreiborza, chargome, mydea and s1gr1d and removed request for a team July 10, 2026 03:36
@linear-code

linear-code Bot commented Jul 10, 2026

Copy link
Copy Markdown

@isaacs isaacs force-pushed the isaacs/nestjs-orchestrion-impl branch from 2ace4ec to d7b514a Compare July 10, 2026 03:36
Comment thread packages/nestjs/src/integrations/nest.ts
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 27.61 kB - -
@sentry/browser - with treeshaking flags 26.05 kB - -
@sentry/browser (incl. Tracing) 46.36 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 48.16 kB - -
@sentry/browser (incl. Tracing, Profiling) 51.15 kB - -
@sentry/browser (incl. Tracing, Replay) 85.63 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 75.27 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 90.34 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 103 kB - -
@sentry/browser (incl. Feedback) 44.79 kB - -
@sentry/browser (incl. sendFeedback) 32.41 kB - -
@sentry/browser (incl. FeedbackAsync) 37.53 kB - -
@sentry/browser (incl. Metrics) 28.69 kB - -
@sentry/browser (incl. Logs) 28.93 kB - -
@sentry/browser (incl. Metrics & Logs) 29.62 kB - -
@sentry/react 29.4 kB - -
@sentry/react (incl. Tracing) 48.63 kB - -
@sentry/vue 33.04 kB - -
@sentry/vue (incl. Tracing) 48.34 kB - -
@sentry/svelte 27.63 kB - -
CDN Bundle 30.01 kB - -
CDN Bundle (incl. Tracing) 48.34 kB - -
CDN Bundle (incl. Logs, Metrics) 31.59 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 49.65 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 70.82 kB - -
CDN Bundle (incl. Tracing, Replay) 85.84 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 87.16 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 91.65 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 92.92 kB - -
CDN Bundle - uncompressed 89.37 kB - -
CDN Bundle (incl. Tracing) - uncompressed 146.12 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 94.07 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 150.09 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 218.8 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 265.32 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 269.28 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 279.02 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 282.97 kB - -
@sentry/nextjs (client) 51.18 kB - -
@sentry/sveltekit (client) 46.81 kB - -
@sentry/core/server 78.42 kB - -
@sentry/core/browser 64.77 kB - -
@sentry/node-core 62.73 kB +0.01% +1 B 🔺
@sentry/node 125.09 kB - -
@sentry/node (incl. diagnostics channel injection) 139.66 kB +0.23% +315 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 69.96 kB - -
@sentry/node/light 50.73 kB - -
@sentry/node - without tracing 74.1 kB - -
@sentry/aws-serverless 83.32 kB -0.01% -2 B 🔽
@sentry/cloudflare (withSentry) - minified 181.58 kB - -
@sentry/cloudflare (withSentry) 449.49 kB - -

View base workflow run

@isaacs isaacs force-pushed the isaacs/nestjs-extract-helpers branch from 1eb7633 to fa0de85 Compare July 10, 2026 14:16
@isaacs isaacs force-pushed the isaacs/nestjs-orchestrion-impl branch from d7b514a to 9d8bcb6 Compare July 10, 2026 14:16
@isaacs isaacs force-pushed the isaacs/nestjs-extract-helpers branch from fa0de85 to dd92103 Compare July 10, 2026 16:30
@isaacs isaacs force-pushed the isaacs/nestjs-orchestrion-impl branch from 9d8bcb6 to f3a502e Compare July 10, 2026 16:30
@isaacs isaacs force-pushed the isaacs/nestjs-extract-helpers branch from dd92103 to b74dcbd Compare July 10, 2026 16:53
@isaacs isaacs force-pushed the isaacs/nestjs-orchestrion-impl branch from f3a502e to d63141c Compare July 10, 2026 16:53
@isaacs isaacs force-pushed the isaacs/nestjs-extract-helpers branch from b74dcbd to 9315716 Compare July 10, 2026 17:16
@isaacs isaacs force-pushed the isaacs/nestjs-orchestrion-impl branch from d63141c to 9e50193 Compare July 10, 2026 17:16
@isaacs isaacs force-pushed the isaacs/nestjs-extract-helpers branch from 9315716 to 28b5141 Compare July 10, 2026 17:36
@isaacs isaacs force-pushed the isaacs/nestjs-orchestrion-impl branch 3 times, most recently from 03c4d95 to e554559 Compare July 13, 2026 00:42
@isaacs isaacs force-pushed the isaacs/nestjs-extract-helpers branch from 28b5141 to 915478f Compare July 13, 2026 00:42

@JPeer264 JPeer264 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Got 3 comments

Comment thread packages/server-utils/src/orchestrion/config/index.ts Outdated
@isaacs isaacs force-pushed the isaacs/nestjs-extract-helpers branch from 915478f to b49e065 Compare July 13, 2026 14:08
@isaacs isaacs requested a review from a team as a code owner July 13, 2026 14:08
@isaacs isaacs force-pushed the isaacs/nestjs-orchestrion-impl branch from e554559 to 2fa98d0 Compare July 13, 2026 14:08

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2fa98d0. Configure here.

Comment thread packages/server-utils/src/orchestrion/config/index.ts Outdated
Comment thread packages/server-utils/src/orchestrion/config/index.ts Outdated
@isaacs isaacs force-pushed the isaacs/nestjs-extract-helpers branch from b49e065 to 5714894 Compare July 13, 2026 14:15
@isaacs isaacs force-pushed the isaacs/nestjs-orchestrion-impl branch from 2fa98d0 to a01cbf6 Compare July 13, 2026 14:15
@isaacs isaacs force-pushed the isaacs/nestjs-extract-helpers branch from 5714894 to 139ac5e Compare July 13, 2026 15:03
@isaacs isaacs force-pushed the isaacs/nestjs-orchestrion-impl branch from a01cbf6 to 481c2cc Compare July 13, 2026 15:03
@isaacs isaacs force-pushed the isaacs/nestjs-extract-helpers branch from 139ac5e to b4e6fdc Compare July 13, 2026 15:24
@isaacs isaacs force-pushed the isaacs/nestjs-orchestrion-impl branch from 481c2cc to f16df75 Compare July 13, 2026 15:24
@isaacs isaacs force-pushed the isaacs/nestjs-extract-helpers branch from b4e6fdc to 868f6a8 Compare July 13, 2026 15:24
@isaacs isaacs force-pushed the isaacs/nestjs-orchestrion-impl branch from f16df75 to 93a8cbe Compare July 13, 2026 15:24
@isaacs isaacs force-pushed the isaacs/nestjs-extract-helpers branch from 868f6a8 to 0ebbf46 Compare July 13, 2026 15:39
@isaacs isaacs force-pushed the isaacs/nestjs-orchestrion-impl branch from 93a8cbe to 588a170 Compare July 13, 2026 15:39
@isaacs isaacs force-pushed the isaacs/nestjs-extract-helpers branch from 0ebbf46 to 8f95306 Compare July 13, 2026 15:47
@isaacs isaacs force-pushed the isaacs/nestjs-orchestrion-impl branch from 588a170 to e493838 Compare July 13, 2026 15:47
Base automatically changed from isaacs/nestjs-extract-helpers to develop July 13, 2026 18:15
@isaacs isaacs force-pushed the isaacs/nestjs-orchestrion-impl branch from e493838 to 47b1bce Compare July 13, 2026 18:15
Add the NestJS channel subscriber in `@sentry/nestjs`, plus its
code-transform config and channel names in `@sentry/server-utils`.

`nestIntegration` now uses the diagnostics-channel path when orchestrion
is injected and the vendored OTel path otherwise. Only the span origin
differs between the two implementations.

Fix: #20947
Fix: #20904
Fix: #20905
Fix: #20906
Fix: #20907
Fix: JS-2519
Fix: JS-2477
Fix: JS-2478
Fix: JS-2479
Fix: JS-2480
@isaacs isaacs force-pushed the isaacs/nestjs-orchestrion-impl branch from 47b1bce to b5cd115 Compare July 13, 2026 18:16
@isaacs isaacs merged commit 8307401 into develop Jul 13, 2026
221 checks passed
@isaacs isaacs deleted the isaacs/nestjs-orchestrion-impl branch July 13, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants