feat(sveltekit): Register a route provider backed by reported route ids - #23784
Closed
logaretm wants to merge 1 commit into
Closed
feat(sveltekit): Register a route provider backed by reported route ids#23784logaretm wants to merge 1 commit into
logaretm wants to merge 1 commit into
Conversation
SvelteKit has no public route matcher and `page.route.id` is not available synchronously, so the provider answers from route ids the instrumentation has already seen rather than by matching. Uses core's cached provider, so the statefulness stays private and the API stays URL in, string out.
5 tasks
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers a route provider for SvelteKit, for both the Kit 2 and Kit 3 variants.
SvelteKit has no public route matcher and
page.route.idis not available synchronously, so this is a cache-backed provider: it answers from route ids the instrumentation has already reported rather than by matching. Both variants already read the route id to rename the span, so they record it on the way through.Part of #23556