fix(native): avoid reading device mappings as ELF files - #2025
Merged
Conversation
Linux module discovery treated every pathname in /proc/<pid>/maps as a potential ELF file. GPU buffer mappings can be backed by a DRM render node such as /dev/dri/renderD128, which is a character device. Reading it to check the ELF magic waits for DRM events and can block the crash daemon indefinitely. The issue was traced by finding the blocked daemon in drm_read, inspecting its file descriptors, and correlating the open render node with the crashed process's memory mappings. Open mapping paths non-blocking and reject non-regular files before reading ELF data. Apply the validation to module discovery, minidump generation, and symbolization, and cover device and FIFO mappings with a regression test.
jpnurmi
force-pushed
the
jpnurmi/fix/native-elf
branch
from
August 25, 2026 19:13
8ceb829 to
afd6612
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2025 +/- ##
==========================================
- Coverage 74.30% 74.24% -0.07%
==========================================
Files 104 104
Lines 26603 26619 +16
Branches 4841 4844 +3
==========================================
- Hits 19768 19763 -5
- Misses 5486 5505 +19
- Partials 1349 1351 +2 🚀 New features to boost your workflow:
|
limbonaut
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux module discovery treated every pathname in
/proc/<pid>/mapsas a potential ELF file. GPU buffer mappings can be backed by a DRM render node such as/dev/dri/renderD128, which is a character device. Reading it to check the ELF magic waits for DRM events and can block the crash daemon indefinitely.Open mapping paths non-blocking and reject non-regular files before reading ELF data. Apply the validation to module discovery, minidump generation, and symbolization, and cover device and FIFO mappings with a regression test.
💡 Accidentally found while running a hardware-accelerated QtQuick app with the Native backend on my Framework 13 Linux laptop. It would always hang on a native crash.