fix(unwind): prevent section table size overflow - #2028
Closed
jpnurmi wants to merge 3 commits into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2028 +/- ##
==========================================
+ Coverage 74.30% 74.33% +0.03%
==========================================
Files 104 104
Lines 26619 26619
Branches 4844 4844
==========================================
+ Hits 19778 19787 +9
+ Misses 5489 5478 -11
- Partials 1352 1354 +2 🚀 New features to boost your workflow:
|
Calculate malformed ELF section table bounds without overflowing the promoted header fields or their offset sum. Document the local source modification so it is preserved during vendor updates. Fixes: https://github.com/getsentry/sentry-native/security/code-scanning/5
jpnurmi
force-pushed
the
jpnurmi/fix/libunwind-section-table-overflow
branch
from
August 27, 2026 11:10
1c306b2 to
ffcde13
Compare
Collaborator
Author
|
Submitted upstream instead: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calculate malformed ELF section table bounds without overflowing the promoted header fields or their offset sum.
Fixes: https://github.com/getsentry/sentry-native/security/code-scanning/5
Warning
Multiplication result converted to larger type
Multiplication result may overflow 'int' before it is converted to 'unsigned long'.
https://codeql.github.com/codeql-query-help/cpp/cpp-integer-multiplication-cast-to-long/