Skip to content

test(pydantic_ai): Fix instructions test for pydantic-ai >=2.36.0 #7321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericapisani merged 3 commits into from
Sep 1, 2026
+12 −6
Merged

test(pydantic_ai): Fix instructions test for pydantic-ai >=2.36.0 #7321

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8fe9257
test(pydantic_ai): Fix instructions test for pydantic-ai >=2.36.0
ericapisani Aug 31, 2026
28a901f
.
ericapisani Aug 31, 2026
74013b5
lint
ericapisani Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions tests/integrations/pydantic_ai/test_pydantic_ai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2228,15 +2228,15 @@ async def test_invoke_agent_with_instructions(
"""
from pydantic_ai import Agent

# Create agent with instructions (can be string or list)
agent = Agent(
"test",
name="test_instructions",
instructions=["Instruction 1", "Instruction 2"],
system_prompt="System prompt",
)

# Add instructions via _instructions attribute (internal API)
agent._instructions = ["Instruction 1", "Instruction 2"]
agent._system_prompts = ["System prompt"]
# pydantic-ai >=2.36.0 joins multiple instructions with a blank line, earlier versions with a single newline
instructions_separator = "\n\n" if PYDANTIC_AI_VERSION >= (2, 36) else "\n"

sentry_init(
integrations=[PydanticAIIntegration(include_prompts=include_prompts)],
Expand Down Expand Up @@ -2268,7 +2268,10 @@ async def test_invoke_agent_with_instructions(
]
assert json.loads(system_instructions) == [
{"type": "text", "content": "System prompt"},
{"type": "text", "content": "Instruction 1\nInstruction 2"},
{
"type": "text",
"content": f"Instruction 1{instructions_separator}Instruction 2",
},
]
else:
assert SPANDATA.GEN_AI_SYSTEM_INSTRUCTIONS not in chat_span["attributes"]
Expand All @@ -2291,7 +2294,10 @@ async def test_invoke_agent_with_instructions(
system_instructions = chat_span["data"][SPANDATA.GEN_AI_SYSTEM_INSTRUCTIONS]
assert json.loads(system_instructions) == [
{"type": "text", "content": "System prompt"},
{"type": "text", "content": "Instruction 1\nInstruction 2"},
{
"type": "text",
"content": f"Instruction 1{instructions_separator}Instruction 2",
},
]
else:
assert SPANDATA.GEN_AI_SYSTEM_INSTRUCTIONS not in chat_span["data"]
Expand Down
Loading