chore(devcontainer): consolidate and simplify dev/test/ci envs#3020
Open
solnic wants to merge 12 commits into
Open
chore(devcontainer): consolidate and simplify dev/test/ci envs#3020solnic wants to merge 12 commits into
solnic wants to merge 12 commits into
Conversation
d4384fc to
8d5cf5b
Compare
6d04589 to
afebf1f
Compare
11ed496 to
f3569ab
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2a2c499. Configure here.
We don't use it after all and using it just to get chromium headless was an overkill.
8f2388e to
56f4c8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This unifies our dev/test/ci dev container setup:
misefor Ruby installation exclusively.runscript as the entrypoint - no longer needed.ci-runas a simpler wrapper script for executing e2e specs on CI.