ref!(slog): Make RecordMapping non_exhaustive and smaller - #1270
Merged
Conversation
szokeasaurusrex
changed the title
RecordMapping's fields (slog integration)RecordMapping's fields
szokeasaurusrex
changed the title
RecordMapping's fieldsRecordMapping's fields
szokeasaurusrex
force-pushed
the
recordmapping-log
branch
from
July 27, 2026 09:44
3fcb078 to
b6bec31
Compare
szokeasaurusrex
force-pushed
the
recordmapping-slog
branch
from
July 27, 2026 09:44
bdbd239 to
34348b7
Compare
szokeasaurusrex
changed the title
RecordMapping's fields
szokeasaurusrex
force-pushed
the
recordmapping-slog
branch
from
July 27, 2026 11:55
34348b7 to
8a458dd
Compare
szokeasaurusrex
force-pushed
the
recordmapping-log
branch
from
July 27, 2026 12:10
b6bec31 to
49bb95b
Compare
szokeasaurusrex
force-pushed
the
recordmapping-slog
branch
from
July 27, 2026 12:10
8a458dd to
7d12934
Compare
Make RecordMapping non_exhaustive to preserve API flexibility, and correct the ignored large_enum_variant lint by boxing Event
szokeasaurusrex
force-pushed
the
recordmapping-slog
branch
from
July 27, 2026 12:23
f36616c to
0a11573
Compare
szokeasaurusrex
marked this pull request as ready for review
July 27, 2026 12:25
alexander-alderman-webb
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make RecordMapping non_exhaustive to preserve API flexibility, and correct the ignored large_enum_variant lint by boxing Event