Fix uninitialized cell_index on API-created table cells - #392
Open
BetterAndBetterII wants to merge 1 commit into
Open
Fix uninitialized cell_index on API-created table cells#392BetterAndBetterII wants to merge 1 commit into
BetterAndBetterII wants to merge 1 commit into
Conversation
opaque_alloc previously calloc'd a node_cell into the same union as cell_index, so cmark_node_new_with_ext(TABLE_CELL) left a heap pointer where render_html/xml expected a column index and could SEGV. Initialize cell_index to 0 instead. Fixes commonmark#360.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmark_node_new_with_ext()for a table cell leftcell_indexuninitialized becauseopaque_allocwrote a heapnode_cellpointer into the same union.cmark_render_html/cmark_render_xmlthen indexedalignments[]with that garbage and could crash.Initialize
cell_indexto 0 for API-created cells (parse path still sets the real index viaset_cell_index).Fixes #360.
Test plan
api_testcase: create cell withcmark_node_new_with_ext, assertcell_index == 0, render HTML/XML after replacing a header cell./build/api_test/api_test(550 passed)