Create a per-org shared connection for graphql requests - #300
Open
hosom wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
lib/entitlements/service/github.rb — This cache is scoped to a service instance, not to an organization. GitHubOrg::Provider and… |
What changed in this PR
Introduces persistent GraphQL HTTP connections to reduce repeated TCP/TLS handshakes.
Changes:
- Reuses started
Net::HTTPconnections. - Resets failed connections.
- Adds reuse and failure-path tests.
| File | Description |
|---|---|
lib/entitlements/service/github.rb |
Adds persistent connection management. |
spec/unit/entitlements/service/github_spec.rb |
Tests connection reuse and recovery. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
converliz
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we make graphql requests at the moment, every single request spawns a new http object and pays for it in a full tcp and tls handshake.
My suggestion is that we create a single connection per-org and speed things up a little.
It's hard to say what the practical improvement will be with the cache in the loop, but on a cold start this could actually shave a minute or more of deploy time.