714 - Adding jsxA11y plugin support back#715
Merged
manuelpuyol merged 1 commit intoJul 10, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Restores eslint-plugin-jsx-a11y’s recommended rule set in the flat React config by explicitly merging the recommended rules into this plugin’s rules object, preventing the shallow-spread overwrite described in issue #714.
Changes:
- Merge
jsxA11yPlugin.flatConfigs.recommended.rulesinto the config’srulesto preserve the full recommended baseline. - Keep existing GitHub-specific overrides (and the temporary disable for
jsx-a11y/role-supports-aria-props) applied after the recommended rules.
Show a summary per file
| File | Description |
|---|---|
| lib/configs/flat/react.js | Merges jsx-a11y recommended rules into the final rules object so they aren’t dropped by the config’s later rules definition. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
manuelpuyol
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #714
Adding
...jsxA11yPlugin.flatConfigs.recommended.rules,at rule level to avoid later override. More details on 714