Draft
feat(linters): add stringscountcontains linter#44820
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
… comment Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add stringscountcontains linter
feat(linters): add stringscountcontains linter
Jul 10, 2026
Contributor
PR TriageCategory: feature | Risk: low | Priority: low | Score: 30/100 (impact:15, urgency:5, quality:10) | Action: batch_review | Batch: pr-batch:draft-review Adds stringscountcontains linter flagging inefficient strings.Count comparisons. Additive/low-risk. Still a draft; no CI yet. Grouped with other draft PRs for batch review.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
stringscountcontainscustom Go analysis linter that flagsstrings.Count(s, sub)comparisons with0or1used purely as containment checks.strings.Countwalks the entire string whilestrings.Containsshort-circuits on first match — making the latter both clearer in intent and more efficient.Flagged patterns → suggested fix
Changes
pkg/linters/stringscountcontains/— new analyzer package; emitsSuggestedFixtext edits for automated batch repair; respects//nolint:stringscountcontainsdirectives; skips_test.gofilesstringscountcontains_test.go— usesanalysistest.RunWithSuggestedFixeswith a.go.goldenfile, consistent with other fix-emitting linterscmd/linters/main.go— registered in the multichecker binarypkg/linters/README.md— documented in overview list, subpackages table, and import paths sectionpkg/linters/spec_test.go— added todocumentedAnalyzers()(39 → 40 documented analyzers)