modified how 3D mouse buttons work by githubdoe · Pull Request #381 · githubdoe/DFTFringe

githubdoe · 2026-08-24T23:25:43Z

Modified what 3D graph mouse button and wheel does. Left rotates, right pans, wheel zooms.

Closes #380

atsju · 2026-08-25T06:08:28Z

+#include <Q3DInputHandler>
+#include <QMouseEvent>


those are not needed. they are managed by #include "custom3dinputhandler.h" and ony needed by itself.

Remove from here.

Suggested change

#include <Q3DInputHandler>

#include <QMouseEvent>

github-actions · 2026-08-25T06:19:06Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v21.1.8) reports: 6 concern(s)

custom3dinputhandler.cpp:23:51: warning: [clang-diagnostic-deprecated-declarations]

'localPos' is deprecated: Use position()

   23 |     QMouseEvent customEvent(event->type(), event->localPos(), event->globalPos(),
      |                                                   ^
/usr/include/x86_64-linux-gnu/qt6/QtGui/qevent.h:226:5: note: 'localPos' has been explicitly marked deprecated here
  226 |     QT_DEPRECATED_VERSION_X_6_0("Use position()")
      |     ^
/usr/include/x86_64-linux-gnu/qt6/QtCore/qglobal.h:326:44: note: expanded from macro 'QT_DEPRECATED_VERSION_X_6_0'
  326 | # define QT_DEPRECATED_VERSION_X_6_0(text) QT_DEPRECATED_X(text)
      |                                            ^
/usr/include/x86_64-linux-gnu/qt6/QtCore/qglobal.h:238:33: note: expanded from macro 'QT_DEPRECATED_X'
  238 | #  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)
      |                                 ^
/usr/include/x86_64-linux-gnu/qt6/QtCore/qcompilerdetection.h:956:36: note: expanded from macro 'Q_DECL_DEPRECATED_X'
  956 | #  define Q_DECL_DEPRECATED_X(x) [[deprecated(x)]]
      |                                    ^

custom3dinputhandler.cpp:23:70: warning: [clang-diagnostic-deprecated-declarations]

'globalPos' is deprecated: Use globalPosition()

   23 |     QMouseEvent customEvent(event->type(), event->localPos(), event->globalPos(),
      |                                                                      ^
/usr/include/x86_64-linux-gnu/qt6/QtGui/qevent.h:215:5: note: 'globalPos' has been explicitly marked deprecated here
  215 |     QT_DEPRECATED_VERSION_X_6_0("Use globalPosition()")
      |     ^
/usr/include/x86_64-linux-gnu/qt6/QtCore/qglobal.h:326:44: note: expanded from macro 'QT_DEPRECATED_VERSION_X_6_0'
  326 | # define QT_DEPRECATED_VERSION_X_6_0(text) QT_DEPRECATED_X(text)
      |                                            ^
/usr/include/x86_64-linux-gnu/qt6/QtCore/qglobal.h:238:33: note: expanded from macro 'QT_DEPRECATED_X'
  238 | #  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)
      |                                 ^
/usr/include/x86_64-linux-gnu/qt6/QtCore/qcompilerdetection.h:956:36: note: expanded from macro 'Q_DECL_DEPRECATED_X'
  956 | #  define Q_DECL_DEPRECATED_X(x) [[deprecated(x)]]
      |                                    ^

custom3dinputhandler.cpp:41:51: warning: [clang-diagnostic-deprecated-declarations]

'localPos' is deprecated: Use position()

   41 |     QMouseEvent customEvent(event->type(), event->localPos(), event->globalPos(),
      |                                                   ^
/usr/include/x86_64-linux-gnu/qt6/QtGui/qevent.h:226:5: note: 'localPos' has been explicitly marked deprecated here
  226 |     QT_DEPRECATED_VERSION_X_6_0("Use position()")
      |     ^
/usr/include/x86_64-linux-gnu/qt6/QtCore/qglobal.h:326:44: note: expanded from macro 'QT_DEPRECATED_VERSION_X_6_0'
  326 | # define QT_DEPRECATED_VERSION_X_6_0(text) QT_DEPRECATED_X(text)
      |                                            ^
/usr/include/x86_64-linux-gnu/qt6/QtCore/qglobal.h:238:33: note: expanded from macro 'QT_DEPRECATED_X'
  238 | #  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)
      |                                 ^
/usr/include/x86_64-linux-gnu/qt6/QtCore/qcompilerdetection.h:956:36: note: expanded from macro 'Q_DECL_DEPRECATED_X'
  956 | #  define Q_DECL_DEPRECATED_X(x) [[deprecated(x)]]
      |                                    ^

custom3dinputhandler.cpp:41:70: warning: [clang-diagnostic-deprecated-declarations]

'globalPos' is deprecated: Use globalPosition()

   41 |     QMouseEvent customEvent(event->type(), event->localPos(), event->globalPos(),
      |                                                                      ^
/usr/include/x86_64-linux-gnu/qt6/QtGui/qevent.h:215:5: note: 'globalPos' has been explicitly marked deprecated here
  215 |     QT_DEPRECATED_VERSION_X_6_0("Use globalPosition()")
      |     ^
/usr/include/x86_64-linux-gnu/qt6/QtCore/qglobal.h:326:44: note: expanded from macro 'QT_DEPRECATED_VERSION_X_6_0'
  326 | # define QT_DEPRECATED_VERSION_X_6_0(text) QT_DEPRECATED_X(text)
      |                                            ^
/usr/include/x86_64-linux-gnu/qt6/QtCore/qglobal.h:238:33: note: expanded from macro 'QT_DEPRECATED_X'
  238 | #  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)
      |                                 ^
/usr/include/x86_64-linux-gnu/qt6/QtCore/qcompilerdetection.h:956:36: note: expanded from macro 'Q_DECL_DEPRECATED_X'
  956 | #  define Q_DECL_DEPRECATED_X(x) [[deprecated(x)]]
      |                                    ^

custom3dinputhandler.cpp:70:51: warning: [clang-diagnostic-deprecated-declarations]

'localPos' is deprecated: Use position()

   70 |     QMouseEvent customEvent(event->type(), event->localPos(), event->globalPos(),
      |                                                   ^
/usr/include/x86_64-linux-gnu/qt6/QtGui/qevent.h:226:5: note: 'localPos' has been explicitly marked deprecated here
  226 |     QT_DEPRECATED_VERSION_X_6_0("Use position()")
      |     ^
/usr/include/x86_64-linux-gnu/qt6/QtCore/qglobal.h:326:44: note: expanded from macro 'QT_DEPRECATED_VERSION_X_6_0'
  326 | # define QT_DEPRECATED_VERSION_X_6_0(text) QT_DEPRECATED_X(text)
      |                                            ^
/usr/include/x86_64-linux-gnu/qt6/QtCore/qglobal.h:238:33: note: expanded from macro 'QT_DEPRECATED_X'
  238 | #  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)
      |                                 ^
/usr/include/x86_64-linux-gnu/qt6/QtCore/qcompilerdetection.h:956:36: note: expanded from macro 'Q_DECL_DEPRECATED_X'
  956 | #  define Q_DECL_DEPRECATED_X(x) [[deprecated(x)]]
      |                                    ^

custom3dinputhandler.cpp:70:70: warning: [clang-diagnostic-deprecated-declarations]

'globalPos' is deprecated: Use globalPosition()

   70 |     QMouseEvent customEvent(event->type(), event->localPos(), event->globalPos(),
      |                                                                      ^
/usr/include/x86_64-linux-gnu/qt6/QtGui/qevent.h:215:5: note: 'globalPos' has been explicitly marked deprecated here
  215 |     QT_DEPRECATED_VERSION_X_6_0("Use globalPosition()")
      |     ^
/usr/include/x86_64-linux-gnu/qt6/QtCore/qglobal.h:326:44: note: expanded from macro 'QT_DEPRECATED_VERSION_X_6_0'
  326 | # define QT_DEPRECATED_VERSION_X_6_0(text) QT_DEPRECATED_X(text)
      |                                            ^
/usr/include/x86_64-linux-gnu/qt6/QtCore/qglobal.h:238:33: note: expanded from macro 'QT_DEPRECATED_X'
  238 | #  define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text)
      |                                 ^
/usr/include/x86_64-linux-gnu/qt6/QtCore/qcompilerdetection.h:956:36: note: expanded from macro 'Q_DECL_DEPRECATED_X'
  956 | #  define Q_DECL_DEPRECATED_X(x) [[deprecated(x)]]
      |                                    ^

Have any feedback or feature suggestions? Share it here.

github-actions

Cpp-linter Review

Used clang-tidy v21.1.8

Only 3 out of 6 clang-tidy concerns fit within this pull request's diff.

Have any feedback or feature suggestions? Share it here.

github-actions · 2026-08-25T06:19:08Z

+        mappedButtons = (mappedButtons & ~Qt::LeftButton) | Qt::RightButton;
+    }
+
+    QMouseEvent customEvent(event->type(), event->localPos(), event->globalPos(),


clang-tidy diagnostic

custom3dinputhandler.cpp:23:51: warning: [clang-diagnostic-deprecated-declarations]

'localPos' is deprecated: Use position()

23 | QMouseEvent customEvent(event->type(), event->localPos(), event->globalPos(), | ^ /usr/include/x86_64-linux-gnu/qt6/QtGui/qevent.h:226:5: note: 'localPos' has been explicitly marked deprecated here 226 | QT_DEPRECATED_VERSION_X_6_0("Use position()") | ^ /usr/include/x86_64-linux-gnu/qt6/QtCore/qglobal.h:326:44: note: expanded from macro 'QT_DEPRECATED_VERSION_X_6_0' 326 | # define QT_DEPRECATED_VERSION_X_6_0(text) QT_DEPRECATED_X(text) | ^ /usr/include/x86_64-linux-gnu/qt6/QtCore/qglobal.h:238:33: note: expanded from macro 'QT_DEPRECATED_X' 238 | # define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text) | ^ /usr/include/x86_64-linux-gnu/qt6/QtCore/qcompilerdetection.h:956:36: note: expanded from macro 'Q_DECL_DEPRECATED_X' 956 | # define Q_DECL_DEPRECATED_X(x) [[deprecated(x)]] | ^

clang-tidy diagnostic

custom3dinputhandler.cpp:23:70: warning: [clang-diagnostic-deprecated-declarations]

'globalPos' is deprecated: Use globalPosition()

23 | QMouseEvent customEvent(event->type(), event->localPos(), event->globalPos(), | ^ /usr/include/x86_64-linux-gnu/qt6/QtGui/qevent.h:215:5: note: 'globalPos' has been explicitly marked deprecated here 215 | QT_DEPRECATED_VERSION_X_6_0("Use globalPosition()") | ^ /usr/include/x86_64-linux-gnu/qt6/QtCore/qglobal.h:326:44: note: expanded from macro 'QT_DEPRECATED_VERSION_X_6_0' 326 | # define QT_DEPRECATED_VERSION_X_6_0(text) QT_DEPRECATED_X(text) | ^ /usr/include/x86_64-linux-gnu/qt6/QtCore/qglobal.h:238:33: note: expanded from macro 'QT_DEPRECATED_X' 238 | # define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text) | ^ /usr/include/x86_64-linux-gnu/qt6/QtCore/qcompilerdetection.h:956:36: note: expanded from macro 'Q_DECL_DEPRECATED_X' 956 | # define Q_DECL_DEPRECATED_X(x) [[deprecated(x)]] | ^

github-actions · 2026-08-25T06:19:08Z

+        mappedButtons = (mappedButtons & ~Qt::LeftButton) | Qt::RightButton;
+    }
+
+    QMouseEvent customEvent(event->type(), event->localPos(), event->globalPos(),


clang-tidy diagnostic

custom3dinputhandler.cpp:41:51: warning: [clang-diagnostic-deprecated-declarations]

'localPos' is deprecated: Use position()

41 | QMouseEvent customEvent(event->type(), event->localPos(), event->globalPos(), | ^ /usr/include/x86_64-linux-gnu/qt6/QtGui/qevent.h:226:5: note: 'localPos' has been explicitly marked deprecated here 226 | QT_DEPRECATED_VERSION_X_6_0("Use position()") | ^ /usr/include/x86_64-linux-gnu/qt6/QtCore/qglobal.h:326:44: note: expanded from macro 'QT_DEPRECATED_VERSION_X_6_0' 326 | # define QT_DEPRECATED_VERSION_X_6_0(text) QT_DEPRECATED_X(text) | ^ /usr/include/x86_64-linux-gnu/qt6/QtCore/qglobal.h:238:33: note: expanded from macro 'QT_DEPRECATED_X' 238 | # define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text) | ^ /usr/include/x86_64-linux-gnu/qt6/QtCore/qcompilerdetection.h:956:36: note: expanded from macro 'Q_DECL_DEPRECATED_X' 956 | # define Q_DECL_DEPRECATED_X(x) [[deprecated(x)]] | ^

clang-tidy diagnostic

custom3dinputhandler.cpp:41:70: warning: [clang-diagnostic-deprecated-declarations]

'globalPos' is deprecated: Use globalPosition()

41 | QMouseEvent customEvent(event->type(), event->localPos(), event->globalPos(), | ^ /usr/include/x86_64-linux-gnu/qt6/QtGui/qevent.h:215:5: note: 'globalPos' has been explicitly marked deprecated here 215 | QT_DEPRECATED_VERSION_X_6_0("Use globalPosition()") | ^ /usr/include/x86_64-linux-gnu/qt6/QtCore/qglobal.h:326:44: note: expanded from macro 'QT_DEPRECATED_VERSION_X_6_0' 326 | # define QT_DEPRECATED_VERSION_X_6_0(text) QT_DEPRECATED_X(text) | ^ /usr/include/x86_64-linux-gnu/qt6/QtCore/qglobal.h:238:33: note: expanded from macro 'QT_DEPRECATED_X' 238 | # define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text) | ^ /usr/include/x86_64-linux-gnu/qt6/QtCore/qcompilerdetection.h:956:36: note: expanded from macro 'Q_DECL_DEPRECATED_X' 956 | # define Q_DECL_DEPRECATED_X(x) [[deprecated(x)]] | ^

github-actions · 2026-08-25T06:19:08Z

+        mappedButtons = (mappedButtons & ~Qt::LeftButton) | Qt::RightButton;
+    }
+
+    QMouseEvent customEvent(event->type(), event->localPos(), event->globalPos(),


clang-tidy diagnostic

custom3dinputhandler.cpp:70:51: warning: [clang-diagnostic-deprecated-declarations]

'localPos' is deprecated: Use position()

70 | QMouseEvent customEvent(event->type(), event->localPos(), event->globalPos(), | ^ /usr/include/x86_64-linux-gnu/qt6/QtGui/qevent.h:226:5: note: 'localPos' has been explicitly marked deprecated here 226 | QT_DEPRECATED_VERSION_X_6_0("Use position()") | ^ /usr/include/x86_64-linux-gnu/qt6/QtCore/qglobal.h:326:44: note: expanded from macro 'QT_DEPRECATED_VERSION_X_6_0' 326 | # define QT_DEPRECATED_VERSION_X_6_0(text) QT_DEPRECATED_X(text) | ^ /usr/include/x86_64-linux-gnu/qt6/QtCore/qglobal.h:238:33: note: expanded from macro 'QT_DEPRECATED_X' 238 | # define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text) | ^ /usr/include/x86_64-linux-gnu/qt6/QtCore/qcompilerdetection.h:956:36: note: expanded from macro 'Q_DECL_DEPRECATED_X' 956 | # define Q_DECL_DEPRECATED_X(x) [[deprecated(x)]] | ^

clang-tidy diagnostic

custom3dinputhandler.cpp:70:70: warning: [clang-diagnostic-deprecated-declarations]

'globalPos' is deprecated: Use globalPosition()

70 | QMouseEvent customEvent(event->type(), event->localPos(), event->globalPos(), | ^ /usr/include/x86_64-linux-gnu/qt6/QtGui/qevent.h:215:5: note: 'globalPos' has been explicitly marked deprecated here 215 | QT_DEPRECATED_VERSION_X_6_0("Use globalPosition()") | ^ /usr/include/x86_64-linux-gnu/qt6/QtCore/qglobal.h:326:44: note: expanded from macro 'QT_DEPRECATED_VERSION_X_6_0' 326 | # define QT_DEPRECATED_VERSION_X_6_0(text) QT_DEPRECATED_X(text) | ^ /usr/include/x86_64-linux-gnu/qt6/QtCore/qglobal.h:238:33: note: expanded from macro 'QT_DEPRECATED_X' 238 | # define QT_DEPRECATED_X(text) Q_DECL_DEPRECATED_X(text) | ^ /usr/include/x86_64-linux-gnu/qt6/QtCore/qcompilerdetection.h:956:36: note: expanded from macro 'Q_DECL_DEPRECATED_X' 956 | # define Q_DECL_DEPRECATED_X(x) [[deprecated(x)]] | ^

github-actions · 2026-08-25T06:25:47Z

🚀 New build available for commit f1375c4
Download installer here

atsju · 2026-08-25T06:46:53Z

Hi Dale,
Congrats on the git usage. Looks like you are mastering it.

I fixed automated build. There are some remaining deprecation warnings that need to be fixed but the build is OK.

The feature is absolutely amazing and I love it.

Being used to 3D sodftwares, there is one flaw though:
right click + up/down or left/right motion always moves allong Y and X repectively. This is only good when you look from top.
If you ever rotated the 3D, all movements become more or less nonsensical.

Here is a capture of the "problem". Video was too large so there are 2 parts.

https://github.com/user-attachments/assets/fb927c69-8c56-433d-a345-d49c009ad9e4
https://github.com/user-attachments/assets/acf36f8c-24e5-4996-b945-d96e075e2ea5

But to be honnest I like this that much that I would like to get it merged and enhanced in a different PR.

One last note: I would advocate to make the right click "orbit". Because this is the way it was in the past. And while I don't care which click does what, I think it's better to keep some some of backcompatiblity and only modify/enhance what left click is doing.

githubdoe · 2026-08-25T08:05:07Z

The older versions use to be left click orbit. So that just restored to the old way and the way I find much 3D apps that I use.

githubdoe · 2026-08-25T08:08:25Z

Yes pan gets a little weird if you rotate too much. I bet we could get AI to fix that by remembering the current rotation.

githubdoe · 2026-08-25T08:30:33Z

Currently have the pan fixed in my local temp branch. Now trying on my local master.

atsju · 2026-08-25T08:30:37Z

Dale, do no forget to git pull your branch before you start modifications. That'"s because I made 2 commits on your remote branch for the .pro files and QT5 compatibility.

I do not expect any conflicts. But it's easier it you pull from the start than doing after you modified/commited on your local copy

githubdoe · 2026-08-25T08:42:58Z

Yes I finally got the pull figured out and the push is now done.

githubdoe and others added 2 commits August 24, 2026 16:43

modified how 3D mouse buttons work

a7e8b06

fixing all .pro files

1ac8e11

atsju reviewed Aug 25, 2026

View reviewed changes

QT5/QT6 compatibility issue

f1375c4

github-actions Bot reviewed Aug 25, 2026

View reviewed changes

githubdoe added 2 commits August 25, 2026 03:32

fixed pan when scene is rotated. More or less

a530b82

Updating from remote

f379740

Navigation Menu

modified how 3D mouse buttons work - #381

modified how 3D mouse buttons work#381
githubdoe wants to merge 5 commits into
masterfrom
3dmouse

githubdoe commented Aug 24, 2026 •

edited by atsju

Loading

Uh oh!

atsju Aug 25, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

github-actions Bot left a comment

Uh oh!

github-actions Bot Aug 25, 2026

Uh oh!

github-actions Bot Aug 25, 2026

Uh oh!

github-actions Bot Aug 25, 2026

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

atsju commented Aug 25, 2026

Uh oh!

githubdoe commented Aug 25, 2026

Uh oh!

githubdoe commented Aug 25, 2026

Uh oh!

githubdoe commented Aug 25, 2026

Uh oh!

atsju commented Aug 25, 2026

Uh oh!

githubdoe commented Aug 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

githubdoe commented Aug 24, 2026 • edited by atsju Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

atsju Aug 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Aug 25, 2026

Cpp-Linter Report ⚠️

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-tidy v21.1.8

Uh oh!

github-actions Bot Aug 25, 2026

Choose a reason for hiding this comment

clang-tidy diagnostic

clang-tidy diagnostic

Uh oh!

github-actions Bot Aug 25, 2026

Choose a reason for hiding this comment

clang-tidy diagnostic

clang-tidy diagnostic

Uh oh!

github-actions Bot Aug 25, 2026

Choose a reason for hiding this comment

clang-tidy diagnostic

clang-tidy diagnostic

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

atsju commented Aug 25, 2026

Uh oh!

githubdoe commented Aug 25, 2026

Uh oh!

githubdoe commented Aug 25, 2026

Uh oh!

githubdoe commented Aug 25, 2026

Uh oh!

atsju commented Aug 25, 2026

Uh oh!

githubdoe commented Aug 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

githubdoe commented Aug 24, 2026 •

edited by atsju

Loading