feat(lfs): support FastCDC media transport - #2178
Conversation
Signed-off-by: Henry Guo <marshawcoco@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 76b6b234fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Henry Guo <marshawcoco@gmail.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Signed-off-by: Henry Guo <marshawcoco@gmail.com>
Summary
fastcdcLFS media extension under the repository-scoped/info/lfs/libra/media/v1APIfastcdc-v1boundaries before publicationThis is the server half of a coordinated Libra client change. Libra companion PR: libra-tools/libra#461
Verification
cargo test -p io-orbit --lib: 11 passedcargo test -p ceres --features fastcdc --lib lfs::: 20 passedcargo test -p mono --features fastcdc --lib lfs_router::: 19 passed, 1 interop helper ignored--no-deps -D warningsClippy commands passed after the validation fixes in this commitfalsewhile backendheadfailures propagate as storage errorsThe Windows workspace suite is not fully green: three Ceres path-separator assertions and the
orion-schedulerUnix-signal compile errors reproduce on the clean upstream baseline. This PR does not claim full workspace CI is green.Deployment boundary
The feature is disabled by default. The fixture uses loopback HTTP, isolated SQLite, Local object storage, and test tokens. Production Mono startup, the real
libra auth logincredential path, S3/GCS compatibility, shared-repository ACLs, quotas, orphan GC, and incomplete multipart cleanup were not validated and remain rollout requirements.CI follow-up — 2026-08-31
Follow-up head:
39fa85e7622ce6312ffb03679fde23a2af76f42b(signed and pushed). The earlier verification results above are historical; they are not a fresh full-suite or HTTP interop result for this head.44bc65ddpassed Full Test and Services Test. Clippy reported eightresult_large_errfindings introduced by this PR; three files now use smaller error types locally.The new Base CI, Services, and CodeQL runs require maintainer approval (
action_required; the Base run has no jobs yet). Please approve these runs so Rust 1.98 Clippy and the new runtime regressions can execute. The production and cloud-storage validation boundaries above are unchanged.