Update ReturnsNullCollection and ProvidesNull to use NullnessUtils.hasDefinitelyNullBranch() instead of looking only for null literals, allowing them to flag conditional null expressions (e.g., return foo ? bar : null). Also make NullnessUtils and hasDefinitelyNullBranch public to support these checks. - #5974
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_954810744
branch
from
August 16, 2026 17:45
e366103 to
7db2242
Compare
copybara-service
Bot
changed the title
ReturnsNullCollection and ProvidesNull to use NullnessUtils.hasDefinitelyNullBranch() instead of looking only for null literals, allowing them to flag conditional null expressions (e.g., return foo ? bar : null). Also make NullnessUtils and hasDefinitelyNullBranch public to support these checks.
…ls.hasDefinitelyNullBranch()` instead of looking only for `null` literals, allowing them to flag conditional null expressions (e.g., `return foo ? bar : null`). Also make `NullnessUtils` and `hasDefinitelyNullBranch` public to support these checks. Update terrible tests to expect diagnostics now that conditional null returns are flagged. PiperOrigin-RevId: 965584501
copybara-service
Bot
force-pushed
the
test_954810744
branch
from
August 16, 2026 18:15
7db2242 to
609e3e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
ReturnsNullCollectionandProvidesNullto useNullnessUtils.hasDefinitelyNullBranch()instead of looking only fornullliterals, allowing them to flag conditional null expressions (e.g.,return foo ? bar : null). Also makeNullnessUtilsandhasDefinitelyNullBranchpublic to support these checks.Update terrible tests to expect diagnostics now that conditional null returns are flagged.