Skip to content

chore: update googleads bazel test target to v22 in kokoro - #1332

Draft
torreypayne wants to merge 1 commit into
mainfrom
kokoro-ads-v22
Draft

chore: update googleads bazel test target to v22 in kokoro#1332
torreypayne wants to merge 1 commit into
mainfrom
kokoro-ads-v22

Conversation

@torreypayne

@torreypayne torreypayne commented Aug 11, 2026

Copy link
Copy Markdown
Member

Updates the Bazel Google Ads generation target in .kokoro/bazel-test.sh from deprecated v21 to active v22 to fix presubmit failures caused by upstream removal in googleapis/googleapis.

Stack

  1. chore: update googleads bazel test target to v22 in kokoro #1332 (This PR): chore: update googleads bazel test target to v22 in kokoro
  2. chore: bump gapic-showcase version in test harness to 0.42.0 #1330: chore: bump gapic-showcase version in test harness to 0.42.0
  3. test: validate PQC TLS cryptography in showcase integration tests #1331: test: validate PQC TLS cryptography in showcase integration tests

Pre-Flight Engineering Audit Sign-Off

  • 1. Encapsulation Leaks: No test-only attr_reader/attr_accessor added; internal state inspected via instance_variable_get.
  • 2. Concurrency Clarity: Zero raw sleep() calls inside MonitorMixin threads (@pause_cond.wait verified); locks & condition variables explicitly documented.
  • 3. Test Brittleness: No private internal deep-stubs; exponential backoff accumulation and gRPC error recovery paths explicitly tested.
  • 4. DRY Test Boilerplate: Shared polling loops, mock stubs, and test setup centralized in test/helper.rb; zero unbuffered puts/print noise.
  • 5. Native Multi-Version Matrix: Ran bundle exec rake test locally across Ruby 3.2 and Ruby 4.0 (0 failures).

@torreypayne
torreypayne marked this pull request as ready for review August 26, 2026 11:04
@torreypayne
torreypayne requested a review from a team as a code owner August 26, 2026 11:04
@torreypayne
torreypayne marked this pull request as draft August 26, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant