impl(bigtable): disable unrelated log messages in TableApplyWithLogging test#16258
Open
scotthart wants to merge 2 commits into
Open
impl(bigtable): disable unrelated log messages in TableApplyWithLogging test#16258scotthart wants to merge 2 commits into
scotthart wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates a test helper lambda in 'data_integration_test.cc' to disable metrics and avoid log pollution, which changes the 'options' parameter to be passed by value. The reviewer correctly points out that 'options' should be moved using 'std::move' when calling 'MakeDataConnection' to prevent an unnecessary copy of the 'Options' object, adhering to the repository's optimization guidelines.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16258 +/- ##
==========================================
- Coverage 92.27% 92.27% -0.01%
==========================================
Files 2214 2214
Lines 206505 206507 +2
==========================================
- Hits 190556 190549 -7
- Misses 15949 15958 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.