fix: update _SERVICE_ACCOUNT_EMAIL_PATTERN to require .gserviceaccount.com suffix #17748
Open
macastelaz wants to merge 1 commit into
Open
fix: update _SERVICE_ACCOUNT_EMAIL_PATTERN to require .gserviceaccount.com suffix #17748macastelaz wants to merge 1 commit into
macastelaz wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the service account email validation pattern in the Google Compute Engine metadata module to restrict valid emails to those ending with ".gserviceaccount.com". The corresponding unit tests have been updated to reflect this change, asserting that standard email addresses like "test@example.com" are now considered invalid. There are no review comments, so no additional feedback is provided.
macastelaz
force-pushed
the
fix-service-account-email-pattern
branch
4 times, most recently
from
July 16, 2026 21:06
ff2b6ba to
2f417f2
Compare
macastelaz
changed the title
macastelaz
force-pushed
the
fix-service-account-email-pattern
branch
from
July 16, 2026 21:21
2f417f2 to
94a31f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue where some environments provide something that is email-like but is NOT a service account email address when attempting to retrieve the compute SA