Skip to content

Add code to handle One Login passkey page - #321

Merged
lfdebrux merged 1 commit into
mainfrom
ldeb-one-login-passkeys
Jul 28, 2026
Merged

Add code to handle One Login passkey page#321
lfdebrux merged 1 commit into
mainfrom
ldeb-one-login-passkeys

Conversation

@lfdebrux

Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

One Login has enabled a new passkey flow when signing in to their integration environment. Our end to end tests include testing the "get a copy of your answers" feature, which involves signing in to One Login.

This commit adds code to skip past setting up a passkey if the page does appear. As the feature is only enabled in the One Login integration environment, we need to deal with the case when the page does not appear as well.

We should also be prepared for the design/content of the page to change in future, but this commit doesn't really do that.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Has all relevant documentation been updated?

One Login has enabled a new passkey flow when signing in to their
integration environment. Our end to end tests include testing the "get a
copy of your answers" feature, which involves signing in to One Login.

This commit adds code to skip past setting up a passkey if the page does
appear. As the feature is only enabled in the One Login integration
environment, we need to deal with the case when the page does not appear
as well.

We should also be prepared for the design/content of the page to change
in future, but this commit doesn't really do that.
@lfdebrux
lfdebrux added this pull request to the merge queue Jul 28, 2026
Merged via the queue into main with commit 0623b92 Jul 28, 2026
3 checks passed
@lfdebrux
lfdebrux deleted the ldeb-one-login-passkeys branch July 28, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants