fix(hero): keep homepage hero within the visible viewport on mobile - #443
Merged
Conversation
The hero used h-screen inside the wrapper that is offset by the voting banner height, so the section was always 100vh + banner tall and never fit on one screen. On mobile browsers vh also refers to the largest viewport, adding the address bar height on top. Long copy on narrow screens was additionally clipped by overflow-hidden. Use a banner-aware min-height based on svh and w-full instead of w-screen. The front tree is slightly smaller on mobile so it stays fully visible below the copy now that the section is shorter.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hero used h-screen inside the wrapper that is offset by the voting banner height, so the section was always 100vh + banner tall and never fit on one screen. On mobile browsers vh also refers to the largest viewport, adding the address bar height on top. Long copy on narrow screens was additionally clipped by overflow-hidden.
Use a banner-aware min-height based on svh and w-full instead of w-screen. The front tree is slightly smaller on mobile so it stays fully visible below the copy now that the section is shorter.