Skip to content

FE-1431: Build the plugin authoring surface (cycle two) - #9348

Open
lunelson wants to merge 9 commits into
ln/fe-1505-timingfrom
ln/fe-1431-plugins
Open

FE-1431: Build the plugin authoring surface (cycle two)#9348
lunelson wants to merge 9 commits into
ln/fe-1505-timingfrom
ln/fe-1431-plugins

Conversation

@lunelson

Copy link
Copy Markdown
Contributor

🌟 What is the purpose of this PR?

Cycle two of the plugin authoring loop: both plugins and the repertoire are rewritten against the cycle-one review findings, the two key shapes that review demanded are changed (pattern slots and the precision list), and the key catalogue is declared frozen under ADR-0007 decision 9 because the cycle changed no key.

Draft: opened so the stack is visible end to end. The description is completed when the branch is tied off.

🔗 Related links

🚫 Blocked by

  • Stacks on ln/fe-1505-timing; lands after it.

🔍 What does this change?

Pattern slots scoped to failing slots with wildcard validation; alternative precision demands; repertoire teaching conditioned on plugin precision; the cycle-two content pass, review resolution, freeze, and its evidence readout; the Brunch evaluation runner kept in pruned app jobs.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

@vercel

vercel Bot commented Aug 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview Aug 28, 2026 12:50pm
hashdotdesign-tokens Ready Ready Preview Aug 28, 2026 12:50pm
petrinaut Ready Ready Preview Aug 28, 2026 12:50pm
petrinaut-docs Ready Ready Preview Aug 28, 2026 12:50pm

Request Review

lunelson commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

@cursor

cursor Bot commented Aug 26, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Changes are documentation, evaluation evidence indexing, and CI prune path copies; no runtime auth or data-path code in this diff.

Overview
Cycle-two closure for FE-1431: baseline evaluation docs now separate cycle-one live arms under transcripts/cycle-1/, point current condition 4–5 artifacts at the 2026-08-26 runs, and add a catalogue freeze verdict in readout.md (no new harness keys; residual defects routed to harness work).

The rendered teaching snapshot condition-4-system.md is rewritten to match the revised SDCPN plugin and repertoire: demand rows gain alternatives (e.g. spread or spelled out), patterns and guidance expand (lenses, techniques, licenses, motifs, close/stopping outcomes), and prose shifts from “precision” to value grade language. CONTEXT.md aligns Pattern and Repertoire definitions with slot-scoped pattern triggers and precision-conditioned repertoire applicability.

CI: prune.py copies sibling plugin-sdcpn and plugin-gherkin plugin.yaml files when the requested scope is @hashintel/brunch-agent-repertoire, with a unit test—so repertoire tests that load plugins by relative URL work in pruned jobs.

Reviewed by Cursor Bugbot for commit e463952. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team area/tests New or updated tests labels Aug 26, 2026
@lunelson
lunelson deployed to pull-request August 26, 2026 17:20 — with GitHub Actions Active
@lunelson
lunelson deployed to pull-request August 26, 2026 17:20 — with GitHub Actions Active
lunelson and others added 9 commits August 28, 2026 14:32
Optional slot predicates keep kind-indexed prompts live only for the missing fact they address, while load-time checks reject predicates outside the plugin contract.

Co-authored-by: Cursor <cursoragent@cursor.com>
Reject dead predicates that no plugin kind can demand and resolve review findings in the adjacent tests.

Co-authored-by: Cursor <cursoragent@cursor.com>
One semantic slot can now accept either a numeric grade or a spelled-out structure, preserving calendars and qualitative objective rules without duplicate rows.

Co-authored-by: Cursor <cursoragent@cursor.com>
Generic quantity and observed-practice methods now render only for plugin contracts that demand compatible precision, keeping shared defaults relevant without plugin overrides.

Co-authored-by: Cursor <cursoragent@cursor.com>
Fill the ADR's missing selection and guidance, resolve the pressure-review contradictions, and make both plugin cells add specific content without repeating repertoire defaults.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
The Quantiles technique had been rewritten as interval-first plus
confidence while the ladder still defined a spread as typical plus
one-in-ten tails. Teach the ladder, copy sibling plugin.yaml into
pruned repertoire jobs, and restore the cycle-one steering link now
that the archive exists.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) area/tests New or updated tests type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

1 participant