FE-1549: Rotate sweep parameter draws by a seed-derived shift - #9435
Draft
Conversation
3 tasks
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
Range sweeps drew each run's parameter values from a bare per-axis Halton sequence: every experiment explored the identical value sequence regardless of its seed, and deterministic low-discrepancy points are not exchangeable random samples. This rotates each axis's draws by a seed-derived shift (Cranley–Patterson), making them unbiased over the seed while keeping the low-discrepancy convergence, the even early coverage, and prefix stability. Stacked on #9419.
🔗 Related links
🔍 What does this change?
sweepRunFractiontakes the experiment seed and rotates the radical-inverse fraction by a per-axis shift hashed from the seed and the axis index (32-bitMath.imulhash), modulo 1.sweepRangeRunsthreads the seed through; the sweep session passes its experiment seed. A draw depends only on the seed, the axis, and the global run index, so ladder batches still extend the same sequence and the selection cache stays valid.Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
🛡 What tests cover this?
parameter-grid.test.ts(sweepRunFractionsuite, extended) and the existingsweep-session.test.tsrange-draw assertions, which now exercise the seeded path.❓ How to test this?
yarn workspace @hashintel/petrinaut devand open "Simulate / SweepNavigator / Real compute on CPU".🤖 Generated with Claude Code