Adopt the worksheet focus layer in the Simulate view tables - #9446
Draft
kube wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
Stacked on #9420. Adopt the worksheet keyboard-flow layer in the Simulate-mode tables — the scenarios, experiments, optimizations, and metrics lists share one
Tablecomponent whose every row was its own Tab stop with no arrow keys, and whose single click opened the drawer with no way to select a row without opening it.🔗 Related links
FE-XXXX: …once reconnected)🔍 What does this change?
Tabledelegates row focus touseFocusStops: each table is one Tab stop with a roving tabindex, and ArrowUp/ArrowDown walk the rows.useSelectFirstActivation): the first click selects (focuses) a row, a click on the selected row — or Enter/Space — callsonRowSelectand opens the drawer. The focused row shows the inset ring on any focus, not only:focus-visible, so pointer users see the selection.renderActionsper-row action-column API is deleted (no caller existed).onRowSelect(the optimization steps table) stay inert, as before.Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
SimulationContext.selectedScenarioId) — today that is only settable from the Simulation Settings picker. Select-first creates the natural slot for it; wiring it up is a product decision left for a follow-up.🐾 Next steps
🛡 What tests cover this?
table.test.tsx: one Tab stop with roving tabindex, arrow-key row walking, select-first click activation, Enter/Space activation, and inert rows withoutonRowSelect.focus-flow.test.tsx(below in the stack) covers the underlying movement contract.❓ How to test this?
yarn dev, switch the top-bar mode to Simulate.The tables' visuals are unchanged apart from the focus ring; existing docs screenshots stay valid.
🤖 Generated with Claude Code