fix: honor --release-name instead of generating a random release name#841
fix: honor --release-name instead of generating a random release name#841somaz94 wants to merge 1 commit into
Conversation
Signed-off-by: somaz <genius5711@gmail.com>
|
Gentle ping 🙏 — green and ready for review. This makes |
|
Friendly ping 🙂 — this has been green and awaiting review for about 5 weeks now. Happy to rebase or address any feedback whenever a maintainer has a chance to take a look. Thanks for maintaining this project! |
|
Plus one for this PR. I'm running into the same problem in the latest release |
|
@moschramm Thanks for confirming — useful to know it reproduces on The code side has been ready for a while: the change makes The most useful thing you could do is add your 👍 to the PR and describe your concrete blocker (the random suffix making it impossible to assert on release names in your tests). Independent demand from someone other than the author tends to move these along far better than another ping from me. |
|
@somaz94 thank you for your reply. As you said, I would like to have a mechanism to enforce a completely deterministic release name. Specifically, this would allow for more convenient testing in scenarios where i want to hard reference a resource by its name and the name is generated based on the release name. |
|
@moschramm That's exactly what this PR delivers. With So the mechanism you're describing is already implemented and green — it just needs a maintainer to pick it up. Your 👍 and this concrete use case on the PR are the most helpful nudge here. Thanks! |
What this PR does / why we need it:
ct install --release-name <name>was ignored.Chart.CreateInstallParamsonly honored the release name when the chart path resolved to.or/, and unconditionally appended a random suffix — so--release-name go-backendstill producedhelm install go-backend-<random>(see the reproduction in the issue). This uses the provided--release-nameverbatim as the release name (Helm validates the syntax). The namespace derivation is unchanged.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #198Special notes for your reviewer:
TestChart_CreateInstallParamsinpkg/chart/chart_test.go(fails before the fix: the release came out assimple-deployment-<random>instead ofmy-release).go test ./...,go vet ./pkg/chart/,gofmt -l, andgolangci-lint run ./pkg/chart/...are all clean locally.--namespace go-backend --release-name go-backendthe caller now yieldshelm install go-backend --namespace go-backend.