Fix portrait alignment, mobile menu behavior, and hero spacing - #30
Open
hoektoe wants to merge 3 commits into
Open
Fix portrait alignment, mobile menu behavior, and hero spacing#30hoektoe wants to merge 3 commits into
hoektoe wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hoektoe
marked this pull request as ready for review
July 21, 2026 07:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The CTA used the default centered
object-covercrop for a portrait image inside a square mobile frame. The About hero had no explicit media alignment option, and its desktop media column did not consume the available flexible width. Shared hero rounding was applied only to the overflow frame, so the image corner away from the frame edge remained square. The mobile menu links did not explicitly close their dialog or handle same-route scroll position. The shared hero also rendered an empty footer container, so itsgap-16combined with hero and following-section padding.Validation
RESEND_API_KEY=re_dummy yarn build50% 20%focal point; About hero-to-heading gap is 64px; same-route mobile menu selection closes the dialog and returnsscrollYto 0Existing lint debt
A full-file ESLint run on
src/app/about/page.tsxstill reports six pre-existingreact/no-unescaped-entitieserrors in page copy; this PR does not alter those lines.