Fix inconsistent argument parsing behavior across Python versions - #1918
Draft
vinayK34 wants to merge 1 commit into
Draft
Fix inconsistent argument parsing behavior across Python versions#1918vinayK34 wants to merge 1 commit into
vinayK34 wants to merge 1 commit into
Conversation
This change modifies the argument parser to use `parse_intermixed_args()` instead of `parse_known_args()` to ensure consistent behavior across Python versions. This addresses issue httpie#1838 where the position of optional flags like `-v` affects argument parsing differently depending on the Python version. The fix ensures that optional arguments can be placed before or after positional arguments consistently across all supported Python versions (3.11, 3.12, and 3.13+).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #1838 where the position of optional flags like
-vaffects argument parsing differently depending on the Python version.The problem was caused by using
parse_known_args()in the argument parsers, which behaves inconsistently between Python 3.12 and 3.13+. Python 3.13 introduced improvements toargparsethat better handle intermixed optional and positional arguments.By switching to
parse_intermixed_args(), which is available since Python 3.7, we ensure consistent behavior across all supported Python versions (3.11, 3.12, and 3.13+).This change modifies:
httpie/cli/argparser.py: UpdatedBaseHTTPieArgumentParser.parse_args()andHTTPieArgumentParser.parse_args()to useparse_intermixed_args()instead ofparse_known_args()parse_intermixed_args()method toHTTPieManagerArgumentParserfor consistencyFixes #1838