Route non-interactive library messages through loggers - #14682
Open
wunianze666-netizen wants to merge 1 commit into
Open
Route non-interactive library messages through loggers#14682wunianze666-netizen wants to merge 1 commit into
wunianze666-netizen wants to merge 1 commit into
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This consolidates the non-interactive library messages approved in #14479 into one change.
What changed
VectorQuantizerremap initialization details through its module logger atINFO.WARNING.WARNING.The message text is preserved where practical. The LongCat
Warning:prefix is omitted because the log record now carries the warning severity.Fixes #14479.
Validation
The focused tests were written first and reproduced the issue as 6 failures: the expected log records were absent and the original text appeared on stdout. After the implementation:
6 passed— focused regression tests across VQ, Wan Animate, and LongCat19 passed, 31 skipped—tests/models/autoencoders/test_models_vq.py18 passed, 16 skipped—tests/pipelines/wan/test_wan_animate.py4 passed—tests/pipelines/longcat_image/test_prepare_pos_ids.pyruff checkandruff format --checkpassed for all 7 changed filescompileallandgit diff --checkpassedThe repository-wide
utils/check_copies.pycurrently reports pre-existing inconsistencies outside this change. Filtering its output forlongcat_imageproduced no matches, so this PR does not introduce a copied-function inconsistency.AI-assisted contribution
I used Codex to help audit the print sites, implement the changes, and write tests. I read the Coding with AI agents guide, contributor guide, philosophy document, and the relevant model, pipeline, testing, and code-style references.
Final self-review
Before submitting
cc @DN6