Skip to content

chore: Remove dashboard variables feature toggle - #3009

Merged
kodiakhq[bot] merged 4 commits into
mainfrom
cursor/remove-dashboard-variables-toggle-5e76
Aug 27, 2026
Merged

chore: Remove dashboard variables feature toggle#3009
kodiakhq[bot] merged 4 commits into
mainfrom
cursor/remove-dashboard-variables-toggle-5e76

Conversation

@pulpdrew

@pulpdrew pulpdrew commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR removes the dashboard variables feature toggle, so that the feature is enabled everywhere.

Screenshots or video

Screenshot 2026-08-27 at 7 29 08 AM

How to test on Vercel preview

Check that the feature is enabled in the preview environment.

References

  • Linear Issue: Closes HDX-5148

@changeset-bot

changeset-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2b114dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Aug 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview Aug 27, 2026 4:27pm
hyperdx-storybook Ready Ready Preview Aug 27, 2026 4:27pm

Request Review

@greptile-apps

greptile-apps Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes the dashboard-variable feature toggle and enables dashboard variables unconditionally.

  • Removes the environment/config flag and its associated hook and unit tests.
  • Passes dashboard variables directly to dashboard tiles and editing interfaces.
  • Updates Playwright configuration, E2E documentation, and release metadata.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
packages/app/src/DBDashboardPage.tsx Removes feature-flag gating, always supplies dashboard variables, and updates the tooltip to sentence case.
packages/app/src/config.ts Removes the obsolete dashboard-variable configuration constant.
packages/app/playwright.config.ts Removes the dashboard-variable setting from the development and build environments.
packages/app/src/hooks/useIsVariablesEnabled.ts Deletes the hook made obsolete by unconditional feature availability.
packages/app/tests/e2e/features/dashboard-filter-variables.spec.ts Updates test documentation to reflect unconditional dashboard-variable availability.

Reviews (4): Last reviewed commit: "Merge branch 'main' into cursor/remove-d..." | Re-trigger Greptile

Comment thread packages/app/src/DBDashboardPage.tsx Outdated
@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

E2E Test Results

All tests passed • 323 passed • 1 skipped • 1320s

Status Count
✅ Passed 323
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 1

Tests ran across 4 shards in parallel.

View full report →

@github-actions

Copy link
Copy Markdown
Contributor

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

  • Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats
  • Production files changed: 5
  • Production lines changed: 46 (+ 51 in test files, excluded from tier calculation)
  • Branch: cursor/remove-dashboard-variables-toggle-5e76
  • Author: pulpdrew

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Deep Review

✅ No critical issues found.

This is a clean, mechanical removal of the dashboard-variables feature toggle. All consumers of the variables prop are typed to accept it optionally and previously handled undefined gracefully, so passing variables unconditionally is type-safe and behavior-preserving. The renderTileComponent useMemo dependency array correctly drops the removed showFilterVariableOptions while retaining variables, and grep confirms no dangling references to any removed symbol (IS_DASHBOARD_VARIABLES_ENABLED, useIsVariablesEnabled, showFilterVariableOptions). The showVariableOptions prop on DashboardFiltersModal is not vestigial — ServicesDashboardPage.tsx still passes showVariableOptions={false}. The prior tooltip title-case comment is addressed (label="Edit filters and variables").

🔵 P3 nitpicks (1)
  • packages/app/playwright.config.ts:109 — the non-USE_DEV branch still passes NEXT_PUBLIC_ENABLE_DASHBOARD_VARIABLES=true in the yarn start segment, an incomplete removal that is now dead config since config.ts no longer reads the env var (it was already stripped from the dev branch and the yarn build segment).
    • Fix: Remove the leftover NEXT_PUBLIC_ENABLE_DASHBOARD_VARIABLES=true token from the yarn start portion of the build-branch command.
    • maintainability, correctness, testing, project-standards

Reviewers (6): correctness, maintainability, testing, project-standards, kieran-typescript, previous-comments.

Testing gaps: The deleted useIsVariablesEnabled unit test covered deleted code, and the always-on path is exercised by the existing @full-stack e2e spec dashboard-filter-variables.spec.ts; no new coverage is required.

cursoragent and others added 3 commits August 27, 2026 07:35
Enable dashboard variables permanently by removing the
IS_DASHBOARD_VARIABLES_ENABLED / NEXT_PUBLIC_ENABLE_DASHBOARD_VARIABLES
toggle and the useIsVariablesEnabled hook. Variables are now always
passed to dashboard tiles, filters, and the edit-filters modal.

Co-authored-by: Drew Davis <pulpdrew@gmail.com>
Co-authored-by: Drew Davis <pulpdrew@gmail.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@pulpdrew
pulpdrew force-pushed the cursor/remove-dashboard-variables-toggle-5e76 branch from 0475072 to cdc86ff Compare August 27, 2026 11:35
@pulpdrew pulpdrew changed the title Enable dashboard variables permanently by removing feature toggle Enable dashboard variables by removing feature toggle Aug 27, 2026
@pulpdrew pulpdrew changed the title Enable dashboard variables by removing feature toggle chore: Remove dashboard variables feature toggle Aug 27, 2026
@kodiakhq
kodiakhq Bot merged commit 8218078 into main Aug 27, 2026
28 checks passed
@kodiakhq
kodiakhq Bot deleted the cursor/remove-dashboard-variables-toggle-5e76 branch August 27, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge review/tier-2 Low risk — AI review + quick human skim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants