chore: Remove dashboard variables feature toggle - #3009
Conversation
🦋 Changeset detectedLatest commit: 2b114dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR removes the dashboard-variable feature toggle and enables dashboard variables unconditionally.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| packages/app/src/DBDashboardPage.tsx | Removes feature-flag gating, always supplies dashboard variables, and updates the tooltip to sentence case. |
| packages/app/src/config.ts | Removes the obsolete dashboard-variable configuration constant. |
| packages/app/playwright.config.ts | Removes the dashboard-variable setting from the development and build environments. |
| packages/app/src/hooks/useIsVariablesEnabled.ts | Deletes the hook made obsolete by unconditional feature availability. |
| packages/app/tests/e2e/features/dashboard-filter-variables.spec.ts | Updates test documentation to reflect unconditional dashboard-variable availability. |
Reviews (4): Last reviewed commit: "Merge branch 'main' into cursor/remove-d..." | Re-trigger Greptile
E2E Test Results✅ All tests passed • 323 passed • 1 skipped • 1320s
Tests ran across 4 shards in parallel. |
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
Deep Review✅ No critical issues found. This is a clean, mechanical removal of the dashboard-variables feature toggle. All consumers of the 🔵 P3 nitpicks (1)
Reviewers (6): correctness, maintainability, testing, project-standards, kieran-typescript, previous-comments. Testing gaps: The deleted |
Enable dashboard variables permanently by removing the IS_DASHBOARD_VARIABLES_ENABLED / NEXT_PUBLIC_ENABLE_DASHBOARD_VARIABLES toggle and the useIsVariablesEnabled hook. Variables are now always passed to dashboard tiles, filters, and the edit-filters modal. Co-authored-by: Drew Davis <pulpdrew@gmail.com>
Co-authored-by: Drew Davis <pulpdrew@gmail.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
0475072 to
cdc86ff
Compare
Summary
This PR removes the dashboard variables feature toggle, so that the feature is enabled everywhere.
Screenshots or video
How to test on Vercel preview
Check that the feature is enabled in the preview environment.
References