fix(local-notifications)!: read config from LocalNotifications plugin object - #170
Open
jcesarmobile wants to merge 1 commit into
Open
fix(local-notifications)!: read config from LocalNotifications plugin object#170jcesarmobile wants to merge 1 commit into
jcesarmobile wants to merge 1 commit into
Conversation
jcesarmobile
requested review from
OS-pedrogustavobilro,
OS-ruimoreiramendes,
alexgerardojacinto,
andredestro,
eric-horodyski,
markemer and
theproducer
August 28, 2026 14:30
alexgerardojacinto
approved these changes
Aug 28, 2026
jcesarmobile
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix deprecation warnings on CapConfig getString by replacing it with PluginConfig and use LocalNotifications objects to get the values from there.
Technically is a breaking change since before the change is expecting the configuration on the root of the capacitor config object, but it's not really documented and it's a bug as there is no accessors for those values (that should be in Capacitor itself, not in the plugin). Plugins should declare their own configuration, not expect them to be in Capacitor.
Also fixed some code warnings in packages/capacitor-plugin/android/src/main/java/io/ionic/backgroundrunner/plugin/api/Notification.kt
Change Type
Rationale / Problems Fixed
CapConfig.getString is deprecated, replace CapConfig with PluginConfig as it's not deprecated and it's what should be using.
Tests or Reproductions
Screenshots / Media
Platforms Affected
Notes / Comments